Обсуждение: Incomplete sentence in the description for most_common_freqs
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/view-pg-stats.html Description: https://www.postgresql.org/docs/current/view-pg-stats.html#VIEW-PG-STATS It seems the ending clarifying sentence: "(Null when most_common_vals is.)" should rather be: "(Null when most_common_vals is null.)" Thanks, Nacho
PG Doc comments form <noreply@postgresql.org> writes:
> It seems the ending clarifying sentence:
> "(Null when most_common_vals is.)"
> should rather be:
> "(Null when most_common_vals is null.)"
I think it's perfectly good English as-is, if a bit terse.
regards, tom lane
Re: [EXTERNAL] Re: Incomplete sentence in the description for most_common_freqs
От
Nacho Alonso Portillo
Дата:
Thanks Tom!
True it is that is perfectly valid English. However, that interpretation might not result trivial to us non-native English speakers.
Would be great if at some point it could be changed to make it clearer.
BTW, it also appears in the definition of the pg_stats_ext_exprs system view.
Regards,
Nacho
From: Tom Lane <tgl@sss.pgh.pa.us>
Sent: Wednesday, March 13, 2024 3:37 PM
To: Nacho Alonso Portillo <Ignacio.Alonso@microsoft.com>
Cc: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
Subject: [EXTERNAL] Re: Incomplete sentence in the description for most_common_freqs
Sent: Wednesday, March 13, 2024 3:37 PM
To: Nacho Alonso Portillo <Ignacio.Alonso@microsoft.com>
Cc: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
Subject: [EXTERNAL] Re: Incomplete sentence in the description for most_common_freqs
[You don't often get email from tgl@sss.pgh.pa.us. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
PG Doc comments form <noreply@postgresql.org> writes:
> It seems the ending clarifying sentence:
> "(Null when most_common_vals is.)"
> should rather be:
> "(Null when most_common_vals is null.)"
I think it's perfectly good English as-is, if a bit terse.
regards, tom lane
PG Doc comments form <noreply@postgresql.org> writes:
> It seems the ending clarifying sentence:
> "(Null when most_common_vals is.)"
> should rather be:
> "(Null when most_common_vals is null.)"
I think it's perfectly good English as-is, if a bit terse.
regards, tom lane