Обсуждение: pg_language(langispl) column apparently not needed

Поиск
Список
Период
Сортировка

pg_language(langispl) column apparently not needed

От
Antonin Houska
Дата:
I couldn't find a reference to the 'langispl' attribute, so I removed it (see
the diff attached) and the master branch compiled cleanly. Is there yet a
reason to keep it?

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com

diff --git a/src/backend/commands/proclang.c b/src/backend/commands/proclang.c
index c849d65e62..d353b4e3f7 100644
--- a/src/backend/commands/proclang.c
+++ b/src/backend/commands/proclang.c
@@ -112,7 +112,6 @@ CreateProceduralLanguage(CreatePLangStmt *stmt)
     namestrcpy(&langname, languageName);
     values[Anum_pg_language_lanname - 1] = NameGetDatum(&langname);
     values[Anum_pg_language_lanowner - 1] = ObjectIdGetDatum(languageOwner);
-    values[Anum_pg_language_lanispl - 1] = BoolGetDatum(true);
     values[Anum_pg_language_lanpltrusted - 1] = BoolGetDatum(stmt->pltrusted);
     values[Anum_pg_language_lanplcallfoid - 1] = ObjectIdGetDatum(handlerOid);
     values[Anum_pg_language_laninline - 1] = ObjectIdGetDatum(inlineOid);
diff --git a/src/include/catalog/pg_language.h b/src/include/catalog/pg_language.h
index 581372addd..7ff3fb0d08 100644
--- a/src/include/catalog/pg_language.h
+++ b/src/include/catalog/pg_language.h
@@ -36,9 +36,6 @@ CATALOG(pg_language,2612,LanguageRelationId)
     /* Language's owner */
     Oid            lanowner BKI_DEFAULT(POSTGRES) BKI_LOOKUP(pg_authid);
 
-    /* Is a procedural language */
-    bool        lanispl BKI_DEFAULT(f);
-
     /* PL is trusted */
     bool        lanpltrusted BKI_DEFAULT(f);


Re: pg_language(langispl) column apparently not needed

От
Tom Lane
Дата:
Antonin Houska <ah@cybertec.at> writes:
> I couldn't find a reference to the 'langispl' attribute, so I removed it (see
> the diff attached) and the master branch compiled cleanly. Is there yet a
> reason to keep it?

You didn't test pg_dump, I take it.

            regards, tom lane