Обсуждение: [Regression] Incorrect filename in test case comment

Поиск
Список
Период
Сортировка

[Regression] Incorrect filename in test case comment

От
Suraj Kharage
Дата:
Hi,

While browsing the test cases, found that the incorrect filename was there in the test case comment.
The below commit added the custom hash opclass in insert.sql,

--------------------------------------------------------------
commit fafec4cce814b9b15991b62520dc5e5e84655a8a
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date:   Fri Apr 13 12:27:22 2018 -0300

    Use custom hash opclass for hash partition pruning
  --------------------------------------------------------------

and later below commit moved those to test_setup.sql

--------------------------------------------------------------
commit cc50080a828dd4791b43539f5a0f976e535d147c
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date:   Tue Feb 8 15:30:38 2022 -0500

    Rearrange core regression tests to reduce cross-script dependencies. 
--------------------------------------------------------------

but we haven't changed the filename in other test cases.
Did the same in the attached patch.


--
--

Thanks & Regards, 
Suraj kharage, 

Вложения

Re: [Regression] Incorrect filename in test case comment

От
Michael Paquier
Дата:
On Wed, Sep 06, 2023 at 10:48:32AM +0530, Suraj Kharage wrote:
> While browsing the test cases, found that the incorrect filename was there
> in the test case comment.
> The below commit added the custom hash opclass in insert.sql,

--- part_part_test_int4_ops and part_test_text_ops in insert.sql.
+-- part_part_test_int4_ops and part_test_text_ops in test_setup.sql.

Good catch, but part_part_test_int4_ops should be renamed to
part_test_int4_ops, removing the first "part_", no?
--
Michael
Вложения

Re: [Regression] Incorrect filename in test case comment

От
Daniel Gustafsson
Дата:
> On 6 Sep 2023, at 07:18, Suraj Kharage <suraj.kharage@enterprisedb.com> wrote:

> we haven't changed the filename in other test cases.
> Did the same in the attached patch.

Pushed (along with a small typo fix), thanks!

--
Daniel Gustafsson

Re: [Regression] Incorrect filename in test case comment

От
Daniel Gustafsson
Дата:
> On 6 Sep 2023, at 10:19, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Sep 06, 2023 at 10:48:32AM +0530, Suraj Kharage wrote:
>> While browsing the test cases, found that the incorrect filename was there
>> in the test case comment.
>> The below commit added the custom hash opclass in insert.sql,
>
> --- part_part_test_int4_ops and part_test_text_ops in insert.sql.
> +-- part_part_test_int4_ops and part_test_text_ops in test_setup.sql.
>
> Good catch, but part_part_test_int4_ops should be renamed to
> part_test_int4_ops, removing the first "part_", no?

Ah, seems we came to same conclusion when looking simultaneously, I just pushed
the fix with the typo fix.

--
Daniel Gustafsson

Re: [Regression] Incorrect filename in test case comment

От
Suraj Kharage
Дата:
Thanks Daniel and Michael.

On Wed, Sep 6, 2023 at 1:52 PM Daniel Gustafsson <daniel@yesql.se> wrote:
> On 6 Sep 2023, at 10:19, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Sep 06, 2023 at 10:48:32AM +0530, Suraj Kharage wrote:
>> While browsing the test cases, found that the incorrect filename was there
>> in the test case comment.
>> The below commit added the custom hash opclass in insert.sql,
>
> --- part_part_test_int4_ops and part_test_text_ops in insert.sql.
> +-- part_part_test_int4_ops and part_test_text_ops in test_setup.sql.
>
> Good catch, but part_part_test_int4_ops should be renamed to
> part_test_int4_ops, removing the first "part_", no?

Ah, seems we came to same conclusion when looking simultaneously, I just pushed
the fix with the typo fix.

--
Daniel Gustafsson



--
--

Thanks & Regards, 
Suraj kharage,