Обсуждение: Error on help in /src/bin/pg_basebackup/pg_basebackup.c

Hello,

It seams to be an indentation error in src/bin/pg_basebackup/pg_basebackup.c in the usage function concerning :

--waldir and from --manifest-checksums to --no-verify-checksums.

Regards

-- 
Romain MAZIÈRE - SIGMAZ Consilium
romain.maziere@sigmaz-consilium.fr
+33.535.545.085
+33.781.46.36.96
https://sigmaz-consilium.fr

On Fri, Sep 01, 2023 at 12:34:26PM +0200, Romain MAZIÈRE wrote:
> It seams to be an indentation error in src/bin/pg_basebackup/pg_basebackup.c
> in the usage function concerning :
>
> *--waldir* and from *--manifest-checksums* to *--no-verify-checksums*.

I am not sure to understand what you mean here.  Are you referring to
a point of the code in a specific commit and/or version?  If possible,
could you post a patch to show you idea?  The indentation of the
output generated seems OK from here.
--
Michael

As you can see here, --waldir is indented, when it should be at the same level as -T.

Same for all those is bold (if I'm true).

  -T, --tablespace-mapping=ANCIENREP=NOUVEAUREP
                                 déplace le répertoire ANCIENREP en NOUVEAUREP
      --waldir=RÉP_WAL           emplacement du répertoire des journaux de
                                 transactions
  -X, --wal-method=none|fetch|stream
                                 inclut les journaux de transactions requis avec
                                 la méthode spécifiée
Options générales :
  -c, --checkpoint=fast|spread   exécute un CHECKPOINT rapide ou réparti
      --create-slot              crée un slot de réplication
  -l, --label=LABEL              configure le label de sauvegarde
  -v, --verbose                  affiche des messages verbeux
  -V, --version                  affiche la version puis quitte
      --manifest-checksums=SHA{224,256,384,512}|CRC32C|NONE
                                 utilise cet algorithme pour les sommes de
                                 contrôle du manifeste
      --manifest-force-encode    encode tous les noms de fichier dans le
                                 manifeste en hexadécimal
      --no-estimate-size         ne réalise pas d'estimation sur la taille de la
                                 sauvegarde côté serveur
      --no-manifest              supprime la génération de manifeste de
                                 sauvegarde
      --no-slot                  empêche la création de slots de réplication
                                 temporaires
      --no-verify-checksums      ne vérifie pas les sommes de contrôle
  -?, --help                     affiche cette aide puis quitte

On Fri, Sep 01, 2023 at 12:34:26PM +0200, Romain MAZIÈRE wrote:

It seams to be an indentation error in src/bin/pg_basebackup/pg_basebackup.c
in the usage function concerning :

*--waldir* and from *--manifest-checksums* to *--no-verify-checksums*.

I am not sure to understand what you mean here.  Are you referring to
a point of the code in a specific commit and/or version?  If possible,
could you post a patch to show you idea?  The indentation of the
output generated seems OK from here.
--
Michael

On 2023-Sep-01, Romain MAZIÈRE wrote:

> As you can see here, --waldir is indented, when it should be at the same
> level as -T.

This is on purpose actually -- the options that have a short form (-X)
appear more to the left, with their long form at its right after the
comma (--wal-method); the options that only have a long form (--waldir)
have whitespace in the location where the short form would be, if they
had any.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Most hackers will be perfectly comfortable conceptualizing users as entropy
 sources, so let's move on."                               (Nathaniel Smith)

Ok, but this is not the same for pg_restore, for example:

   -1, --single-transaction     restaure dans une seule transaction
   --disable-triggers           désactive les triggers en mode de 
restauration

Le 01/09/2023 à 14:02, Alvaro Herrera a écrit :
> On 2023-Sep-01, Romain MAZIÈRE wrote:
>
>> As you can see here, --waldir is indented, when it should be at the same
>> level as -T.
> This is on purpose actually -- the options that have a short form (-X)
> appear more to the left, with their long form at its right after the
> comma (--wal-method); the options that only have a long form (--waldir)
> have whitespace in the location where the short form would be, if they
> had any.
>

On 2023-Sep-01, Romain MAZIÈRE wrote:

> Ok, but this is not the same for pg_restore, for example:
> 
>   -1, --single-transaction     restaure dans une seule transaction
>   --disable-triggers           désactive les triggers en mode de
> restauration

¯\_(ツ)_/¯

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/