Обсуждение: pgsql: Allow pgbench to exit immediately when any client is aborted.
Allow pgbench to exit immediately when any client is aborted. Previously when client was aborted due to some error during benchmarking, other clients continued their run until certain number of transactions specified -t was reached or the time specified by -T was expired. At the end, the results are printed with caution: "Run was aborted; the above results are incomplete" shows. New option "--exit-on-abort" allows pgbench to exit immediately in this case so that users could quickly fix the cause of the failure and try again another round of benchmarking. Author: Yugo Nagata Reviewed-by: Fabien COELHO, Tatsuo Ishii Discussion: https://postgr.es/m/flat/20230804130325.df32e60879c38c92bca64207%40sraoss.co.jp Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/3c662643c4bb94aaf384e83fcfb53f6e4da0035e Modified Files -------------- doc/src/sgml/ref/pgbench.sgml | 28 ++++++++++++++++++++--- src/bin/pgbench/pgbench.c | 33 +++++++++++++++++++++++++++- src/bin/pgbench/t/001_pgbench_with_server.pl | 26 ++++++++++++++++++++++ 3 files changed, 83 insertions(+), 4 deletions(-)
Hi Ishii-san, On Wed, Aug 30, 2023 at 01:05:15AM +0000, Tatsuo Ishii wrote: > Allow pgbench to exit immediately when any client is aborted. > > Previously when client was aborted due to some error during > benchmarking, other clients continued their run until certain number > of transactions specified -t was reached or the time specified by -T > was expired. At the end, the results are printed with caution: "Run > was aborted; the above results are incomplete" shows. > > New option "--exit-on-abort" allows pgbench to exit immediately in > this case so that users could quickly fix the cause of the failure and > try again another round of benchmarking. Buildfarm member koel is saying that this commit was not properly indented: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2023-08-30%2002%3A19%3A02 Could you address this with a run of pgindent? After the reindent is itself committed, you should also add the commit that did the indentation to .git-blame-ignore-revs. -- Michael
Вложения
> Hi Ishii-san, > > On Wed, Aug 30, 2023 at 01:05:15AM +0000, Tatsuo Ishii wrote: >> Allow pgbench to exit immediately when any client is aborted. >> >> Previously when client was aborted due to some error during >> benchmarking, other clients continued their run until certain number >> of transactions specified -t was reached or the time specified by -T >> was expired. At the end, the results are printed with caution: "Run >> was aborted; the above results are incomplete" shows. >> >> New option "--exit-on-abort" allows pgbench to exit immediately in >> this case so that users could quickly fix the cause of the failure and >> try again another round of benchmarking. > > Buildfarm member koel is saying that this commit was not properly > indented: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2023-08-30%2002%3A19%3A02 > > Could you address this with a run of pgindent? > > After the reindent is itself committed, you should also add the commit > that did the indentation to .git-blame-ignore-revs. Ok, I will do it. Best reagards, -- Tatsuo Ishii SRA OSS LLC English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp