Обсуждение: Broken Urls present on the official PostgreSQL website (as reported by the Testing Harness Suite)

Поиск
Список
Период
Сортировка

Broken Urls present on the official PostgreSQL website (as reported by the Testing Harness Suite)

От
Akshat Jaimini
Дата:
Hello everyone,

Our Testing Harness Suite (being developed under GSoC'23) has found some broken links on the official postgresql website. I am attaching the logs generated below.

The broken links present in the log file attached below are:

--- Links to external sites -----
1. https://www.postgresql.org/docs/current/static/pgstandby.html : 404 : On Page https://www.postgresql.org/about/featurematrix/
2. https://www.postgresql.org/docs/current/static/tsearch2.html : 404 : On Page https://www.postgresql.org/about/featurematrix/
3. https://formulae.brew.sh/formula/postgresql : 404 : On Page https://www.postgresql.org/download/macosx/
4. http://www.digitbooks.fr/catalogue/9782815001984.html : 404 : On Page https://www.postgresql.org/docs/books/
5. http://www.digitbooks.fr/catalogue/9782815001809.html : 404 : On Page https://www.postgresql.org/docs/books/
6. https://www.editions-eni.fr/Livres/PostgreSQL---administration-et-exploitation-d-rsquoune-base-de-donnees-2eme-edition-/.4_3a6222cf-b921-41f5-886c-c989f77ba994_710d51ac-760b-4aeb-a66a-55d146b69983_1_0_d9bd8b5e-f324-473f-b1fc-b41b421c950f.html : 404 : On Page https://www.postgresql.org/docs/books/
7. https://www.commandprompt.com/ppbook/ : 404 : On Page https://www.postgresql.org/docs/books/

If you wish to see all the logs kindly visit this page.
If you want to know more about the testing harness suite yourself on your local machine kindly visit here.
Would like to encourage everyone to use the Testing Harness to check for any errors in the latest builds of the official website.

Regards,
Akshat Jaimini
Вложения

Re: Broken Urls present on the official PostgreSQL website (as reported by the Testing Harness Suite)

От
"Jonathan S. Katz"
Дата:
On 7/24/23 1:40 PM, Akshat Jaimini wrote:
> Hello everyone,
> 
> Our Testing Harness Suite 
> <https://github.com/destrex271/pgweb-testing-harness/actions/runs/5647803781> (being developed under GSoC'23) has
foundsome broken links on the official postgresql website. I am attaching the logs generated below.
 
> 
> The broken links present in the log file attached below are:
> 
> --- Links to external sites -----
> 1. https://www.postgresql.org/docs/current/static/pgstandby.html 
> <https://www.postgresql.org/docs/current/static/pgstandby.html> : 404 : 
> On Page https://www.postgresql.org/about/featurematrix/ 
> <https://www.postgresql.org/about/featurematrix/>
> 2. https://www.postgresql.org/docs/current/static/tsearch2.html 
> <https://www.postgresql.org/docs/current/static/tsearch2.html> : 404 : 
> On Page https://www.postgresql.org/about/featurematrix/ 
> <https://www.postgresql.org/about/featurematrix/>
> 3. https://formulae.brew.sh/formula/postgresql 
> <https://formulae.brew.sh/formula/postgresql> : 404 : On Page 
> https://www.postgresql.org/download/macosx/ 
> <https://www.postgresql.org/download/macosx/>
> 4. http://www.digitbooks.fr/catalogue/9782815001984.html 
> <http://www.digitbooks.fr/catalogue/9782815001984.html> : 404 : On Page 
> https://www.postgresql.org/docs/books/ 
> <https://www.postgresql.org/docs/books/>
> 5. http://www.digitbooks.fr/catalogue/9782815001809.html 
> <http://www.digitbooks.fr/catalogue/9782815001809.html> : 404 : On Page 
> https://www.postgresql.org/docs/books/ 
> <https://www.postgresql.org/docs/books/>
> 6. 
>
https://www.editions-eni.fr/Livres/PostgreSQL---administration-et-exploitation-d-rsquoune-base-de-donnees-2eme-edition-/.4_3a6222cf-b921-41f5-886c-c989f77ba994_710d51ac-760b-4aeb-a66a-55d146b69983_1_0_d9bd8b5e-f324-473f-b1fc-b41b421c950f.html
<https://www.editions-eni.fr/Livres/PostgreSQL---administration-et-exploitation-d-rsquoune-base-de-donnees-2eme-edition-/.4_3a6222cf-b921-41f5-886c-c989f77ba994_710d51ac-760b-4aeb-a66a-55d146b69983_1_0_d9bd8b5e-f324-473f-b1fc-b41b421c950f.html>
:404 : On Page https://www.postgresql.org/docs/books/ <https://www.postgresql.org/docs/books/>
 
> 7. https://www.commandprompt.com/ppbook/ 
> <https://www.commandprompt.com/ppbook/> : 404 : On Page 
> https://www.postgresql.org/docs/books/ 
> <https://www.postgresql.org/docs/books/>

Thanks -- this is a great report and I'm glad the test harness suite can 
catch this!

There's already a patch to remove the 404s on the books[1]; I can take 
care of the feature matrix broken links later today.

Thanks,

Jonathan

[1] 
https://www.postgresql.org/message-id/548027CC-7FCC-4B60-BB93-69DD7733B921%40yesql.se

Вложения
Amazing! I hope this tool comes in handy again.

Thanks,
Akshat Jaimini

On Mon, 24 Jul, 2023, 23:42 Jonathan S. Katz, <jkatz@postgresql.org> wrote:
On 7/24/23 1:40 PM, Akshat Jaimini wrote:
> Hello everyone,
>
> Our Testing Harness Suite
> <https://github.com/destrex271/pgweb-testing-harness/actions/runs/5647803781> (being developed under GSoC'23) has found some broken links on the official postgresql website. I am attaching the logs generated below.
>
> The broken links present in the log file attached below are:
>
> --- Links to external sites -----
> 1. https://www.postgresql.org/docs/current/static/pgstandby.html
> <https://www.postgresql.org/docs/current/static/pgstandby.html> : 404 :
> On Page https://www.postgresql.org/about/featurematrix/
> <https://www.postgresql.org/about/featurematrix/>
> 2. https://www.postgresql.org/docs/current/static/tsearch2.html
> <https://www.postgresql.org/docs/current/static/tsearch2.html> : 404 :
> On Page https://www.postgresql.org/about/featurematrix/
> <https://www.postgresql.org/about/featurematrix/>
> 3. https://formulae.brew.sh/formula/postgresql
> <https://formulae.brew.sh/formula/postgresql> : 404 : On Page
> https://www.postgresql.org/download/macosx/
> <https://www.postgresql.org/download/macosx/>
> 4. http://www.digitbooks.fr/catalogue/9782815001984.html
> <http://www.digitbooks.fr/catalogue/9782815001984.html> : 404 : On Page
> https://www.postgresql.org/docs/books/
> <https://www.postgresql.org/docs/books/>
> 5. http://www.digitbooks.fr/catalogue/9782815001809.html
> <http://www.digitbooks.fr/catalogue/9782815001809.html> : 404 : On Page
> https://www.postgresql.org/docs/books/
> <https://www.postgresql.org/docs/books/>
> 6.
> https://www.editions-eni.fr/Livres/PostgreSQL---administration-et-exploitation-d-rsquoune-base-de-donnees-2eme-edition-/.4_3a6222cf-b921-41f5-886c-c989f77ba994_710d51ac-760b-4aeb-a66a-55d146b69983_1_0_d9bd8b5e-f324-473f-b1fc-b41b421c950f.html <https://www.editions-eni.fr/Livres/PostgreSQL---administration-et-exploitation-d-rsquoune-base-de-donnees-2eme-edition-/.4_3a6222cf-b921-41f5-886c-c989f77ba994_710d51ac-760b-4aeb-a66a-55d146b69983_1_0_d9bd8b5e-f324-473f-b1fc-b41b421c950f.html> : 404 : On Page https://www.postgresql.org/docs/books/ <https://www.postgresql.org/docs/books/>
> 7. https://www.commandprompt.com/ppbook/
> <https://www.commandprompt.com/ppbook/> : 404 : On Page
> https://www.postgresql.org/docs/books/
> <https://www.postgresql.org/docs/books/>

Thanks -- this is a great report and I'm glad the test harness suite can
catch this!

There's already a patch to remove the 404s on the books[1]; I can take
care of the feature matrix broken links later today.

Thanks,

Jonathan

[1]
https://www.postgresql.org/message-id/548027CC-7FCC-4B60-BB93-69DD7733B921%40yesql.se

Re: Broken Urls present on the official PostgreSQL website (as reported by the Testing Harness Suite)

От
"Jonathan S. Katz"
Дата:
On 7/24/23 2:22 PM, Akshat Jaimini wrote:

>      > The broken links present in the log file attached below are:
>      >
>      > --- Links to external sites -----
>      > 1. https://www.postgresql.org/docs/current/static/pgstandby.html
>     <https://www.postgresql.org/docs/current/static/pgstandby.html>
>      > <https://www.postgresql.org/docs/current/static/pgstandby.html
>     <https://www.postgresql.org/docs/current/static/pgstandby.html>> :
>     404 :
>      > On Page https://www.postgresql.org/about/featurematrix/
>     <https://www.postgresql.org/about/featurematrix/>
>      > <https://www.postgresql.org/about/featurematrix/
>     <https://www.postgresql.org/about/featurematrix/>>
>      > 2. https://www.postgresql.org/docs/current/static/tsearch2.html
>     <https://www.postgresql.org/docs/current/static/tsearch2.html>
>      > <https://www.postgresql.org/docs/current/static/tsearch2.html
>     <https://www.postgresql.org/docs/current/static/tsearch2.html>> : 404 :
>      > On Page https://www.postgresql.org/about/featurematrix/
>     <https://www.postgresql.org/about/featurematrix/>
>      > <https://www.postgresql.org/about/featurematrix/
>     <https://www.postgresql.org/about/featurematrix/>>

I was unable to find either of these links when searching the feature 
matrix database. Is there any other info that can narrow down which 
entry these are in? Otherwise, these may have already been removed.

>      > 3. https://formulae.brew.sh/formula/postgresql
>     <https://formulae.brew.sh/formula/postgresql>
>      > <https://formulae.brew.sh/formula/postgresql
>     <https://formulae.brew.sh/formula/postgresql>> : 404 : On Page
>      > https://www.postgresql.org/download/macosx/
>     <https://www.postgresql.org/download/macosx/>
>      > <https://www.postgresql.org/download/macosx/
>     <https://www.postgresql.org/download/macosx/>>

This is in [1] and we just need to bring that thread to conclusion.

Thanks,

Jonathan

[1] 
https://www.postgresql.org/message-id/flat/18018-016a323e1947b6f5%40postgresql.org


Вложения

Re: Broken Urls present on the official PostgreSQL website (as reported by the Testing Harness Suite)

От
Daniel Gustafsson
Дата:
> On 25 Jul 2023, at 04:08, Jonathan S. Katz <jkatz@postgresql.org> wrote:
>
> On 7/24/23 2:22 PM, Akshat Jaimini wrote:
>
>>     > The broken links present in the log file attached below are:
>>     >
>>     > --- Links to external sites -----
>>     > 1. https://www.postgresql.org/docs/current/static/pgstandby.html
>>    <https://www.postgresql.org/docs/current/static/pgstandby.html>
>>     > <https://www.postgresql.org/docs/current/static/pgstandby.html
>>    <https://www.postgresql.org/docs/current/static/pgstandby.html>> :
>>    404 :
>>     > On Page https://www.postgresql.org/about/featurematrix/
>>    <https://www.postgresql.org/about/featurematrix/>
>>     > <https://www.postgresql.org/about/featurematrix/
>>    <https://www.postgresql.org/about/featurematrix/>>
>>     > 2. https://www.postgresql.org/docs/current/static/tsearch2.html
>>    <https://www.postgresql.org/docs/current/static/tsearch2.html>
>>     > <https://www.postgresql.org/docs/current/static/tsearch2.html
>>    <https://www.postgresql.org/docs/current/static/tsearch2.html>> : 404 :
>>     > On Page https://www.postgresql.org/about/featurematrix/
>>    <https://www.postgresql.org/about/featurematrix/>
>>     > <https://www.postgresql.org/about/featurematrix/
>>    <https://www.postgresql.org/about/featurematrix/>>
>
> I was unable to find either of these links when searching the feature matrix database. Is there any other info that
cannarrow down which entry these are in? Otherwise, these may have already been removed. 

I'm guessing this ran against the featurematrix/fixtures/data.json in the pgweb
repo which does contain these links, but which doesn't reflect the actual
website content due to being an initial dataset (in turn generated by the
script pgweb/dump_initial_data.sh).

The data.json being served on the production site is based off the database and
isn't committed to the repository.  A testing harness for the website code
should probably skip checking the validity of dynamic data unless it's running
against the live site for those checks.

--
Daniel Gustafsson




Yup just checked it and we'll make sure to exclude the fixture data. These dynamic urls will be checked by the tests written to check documentation loading and rendering from now on. Will push the change eod today. Apologies for the inconvenience caused with the first two results.
Will share the correct reports asap.

Thanks,
Akshat Jaimini

On Tue, Jul 25, 2023 at 1:01 PM Daniel Gustafsson <daniel@yesql.se> wrote:
> On 25 Jul 2023, at 04:08, Jonathan S. Katz <jkatz@postgresql.org> wrote:
>
> On 7/24/23 2:22 PM, Akshat Jaimini wrote:
>
>>     > The broken links present in the log file attached below are:
>>     >
>>     > --- Links to external sites -----
>>     > 1. https://www.postgresql.org/docs/current/static/pgstandby.html
>>    <https://www.postgresql.org/docs/current/static/pgstandby.html>
>>     > <https://www.postgresql.org/docs/current/static/pgstandby.html
>>    <https://www.postgresql.org/docs/current/static/pgstandby.html>> :
>>    404 :
>>     > On Page https://www.postgresql.org/about/featurematrix/
>>    <https://www.postgresql.org/about/featurematrix/>
>>     > <https://www.postgresql.org/about/featurematrix/
>>    <https://www.postgresql.org/about/featurematrix/>>
>>     > 2. https://www.postgresql.org/docs/current/static/tsearch2.html
>>    <https://www.postgresql.org/docs/current/static/tsearch2.html>
>>     > <https://www.postgresql.org/docs/current/static/tsearch2.html
>>    <https://www.postgresql.org/docs/current/static/tsearch2.html>> : 404 :
>>     > On Page https://www.postgresql.org/about/featurematrix/
>>    <https://www.postgresql.org/about/featurematrix/>
>>     > <https://www.postgresql.org/about/featurematrix/
>>    <https://www.postgresql.org/about/featurematrix/>>
>
> I was unable to find either of these links when searching the feature matrix database. Is there any other info that can narrow down which entry these are in? Otherwise, these may have already been removed.

I'm guessing this ran against the featurematrix/fixtures/data.json in the pgweb
repo which does contain these links, but which doesn't reflect the actual
website content due to being an initial dataset (in turn generated by the
script pgweb/dump_initial_data.sh).

The data.json being served on the production site is based off the database and
isn't committed to the repository.  A testing harness for the website code
should probably skip checking the validity of dynamic data unless it's running
against the live site for those checks.

--
Daniel Gustafsson

With the recent patches, there are no logs related to broken links as generated by the testing harness. 
I think we can mark these issues as completed now!

On Tue, Jul 25, 2023 at 1:42 PM Akshat Jaimini <destrex271@gmail.com> wrote:
Yup just checked it and we'll make sure to exclude the fixture data. These dynamic urls will be checked by the tests written to check documentation loading and rendering from now on. Will push the change eod today. Apologies for the inconvenience caused with the first two results.
Will share the correct reports asap.

Thanks,
Akshat Jaimini

On Tue, Jul 25, 2023 at 1:01 PM Daniel Gustafsson <daniel@yesql.se> wrote:
> On 25 Jul 2023, at 04:08, Jonathan S. Katz <jkatz@postgresql.org> wrote:
>
> On 7/24/23 2:22 PM, Akshat Jaimini wrote:
>
>>     > The broken links present in the log file attached below are:
>>     >
>>     > --- Links to external sites -----
>>     > 1. https://www.postgresql.org/docs/current/static/pgstandby.html
>>    <https://www.postgresql.org/docs/current/static/pgstandby.html>
>>     > <https://www.postgresql.org/docs/current/static/pgstandby.html
>>    <https://www.postgresql.org/docs/current/static/pgstandby.html>> :
>>    404 :
>>     > On Page https://www.postgresql.org/about/featurematrix/
>>    <https://www.postgresql.org/about/featurematrix/>
>>     > <https://www.postgresql.org/about/featurematrix/
>>    <https://www.postgresql.org/about/featurematrix/>>
>>     > 2. https://www.postgresql.org/docs/current/static/tsearch2.html
>>    <https://www.postgresql.org/docs/current/static/tsearch2.html>
>>     > <https://www.postgresql.org/docs/current/static/tsearch2.html
>>    <https://www.postgresql.org/docs/current/static/tsearch2.html>> : 404 :
>>     > On Page https://www.postgresql.org/about/featurematrix/
>>    <https://www.postgresql.org/about/featurematrix/>
>>     > <https://www.postgresql.org/about/featurematrix/
>>    <https://www.postgresql.org/about/featurematrix/>>
>
> I was unable to find either of these links when searching the feature matrix database. Is there any other info that can narrow down which entry these are in? Otherwise, these may have already been removed.

I'm guessing this ran against the featurematrix/fixtures/data.json in the pgweb
repo which does contain these links, but which doesn't reflect the actual
website content due to being an initial dataset (in turn generated by the
script pgweb/dump_initial_data.sh).

The data.json being served on the production site is based off the database and
isn't committed to the repository.  A testing harness for the website code
should probably skip checking the validity of dynamic data unless it's running
against the live site for those checks.

--
Daniel Gustafsson