Обсуждение: pgsql: Improve pg_basebackup long file name test Windows robustness

Поиск
Список
Период
Сортировка

pgsql: Improve pg_basebackup long file name test Windows robustness

От
Andrew Dunstan
Дата:
Improve pg_basebackup long file name test Windows robustness

Creation of a file with a very long name can create problems on Windows
due to its file path limits. Work around that by creating the file via a
symlink with a shorter name.

Error displayed by buildfarm animal fairywren.o

Backpatch to all live branches

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/088e395c8ae06047784c41b08c54d526d00517c9

Modified Files
--------------
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)


Re: pgsql: Improve pg_basebackup long file name test Windows robustness

От
Daniel Gustafsson
Дата:
> On 3 Jul 2023, at 16:08, Andrew Dunstan <andrew@dunslane.net> wrote:
> 
> Improve pg_basebackup long file name test Windows robustness
> 
> Creation of a file with a very long name can create problems on Windows
> due to its file path limits. Work around that by creating the file via a
> symlink with a shorter name.

+dir_symlink "$pgdata", "$lftmp/pgdata";

dir_symlink doesn't exist in REL_12_STABLE.

--
Daniel Gustafsson




Re: pgsql: Improve pg_basebackup long file name test Windows robustness

От
Andrew Dunstan
Дата:


On 2023-07-03 Mo 10:19, Daniel Gustafsson wrote:
On 3 Jul 2023, at 16:08, Andrew Dunstan <andrew@dunslane.net> wrote:

Improve pg_basebackup long file name test Windows robustness

Creation of a file with a very long name can create problems on Windows
due to its file path limits. Work around that by creating the file via a
symlink with a shorter name.
+dir_symlink "$pgdata", "$lftmp/pgdata";

dir_symlink doesn't exist in REL_12_STABLE.


Argh!. ok, thanks, will fix.


cheers


andrew


--
Daniel Gustafsson

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Re: pgsql: Improve pg_basebackup long file name test Windows robustness

От
Andrew Dunstan
Дата:


On 2023-07-03 Mo 10:51, Andrew Dunstan wrote:


On 2023-07-03 Mo 10:19, Daniel Gustafsson wrote:
On 3 Jul 2023, at 16:08, Andrew Dunstan <andrew@dunslane.net> wrote:

Improve pg_basebackup long file name test Windows robustness

Creation of a file with a very long name can create problems on Windows
due to its file path limits. Work around that by creating the file via a
symlink with a shorter name.
+dir_symlink "$pgdata", "$lftmp/pgdata";

dir_symlink doesn't exist in REL_12_STABLE.


Argh!. ok, thanks, will fix.




Neither does rel 13 have it. I've reverted all this for versions older than 14. It means running TAP tests on older version on Windows could be fragile, but at least my animals don't run TAP tests on older versions.


cheers


andrew



--
Andrew Dunstan
EDB: https://www.enterprisedb.com