Обсуждение: [DOCS] alter_foreign_table.sgml typo

Поиск
Список
Период
Сортировка

[DOCS] alter_foreign_table.sgml typo

От
Mehmet Emin KARAKAŞ
Дата:
Fixed typo in SQL.

Current: ALTER FOREIGN TABLE myschema.distributors OPTIONS (ADD opt1 'value', SET opt2 'value2', DROP opt3 'value3');

Fixed: ALTER FOREIGN TABLE myschema.distributors OPTIONS (ADD opt1 'value', SET opt2 'value2', DROP opt3);

Drop options do not get a value.

--
MEHMET EMİN KARAKAŞ
Вложения

Re: [DOCS] alter_foreign_table.sgml typo

От
Fujii Masao
Дата:

On 2023/06/07 23:25, Mehmet Emin KARAKAŞ wrote:
> Fixed typo in SQL.
> 
> Current: ALTER FOREIGN TABLE myschema.distributors OPTIONS (ADD opt1 'value', SET opt2 'value2', DROP opt3
'value3');
> 
> Fixed: ALTER FOREIGN TABLE myschema.distributors OPTIONS (ADD opt1 'value', SET opt2 'value2', DROP opt3);
> 
> Drop options do not get a value.

Thanks for the report! I agree with your findings and the patch looks good to me.
I will commit the patch barring any objection.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Re: [DOCS] alter_foreign_table.sgml typo

От
Fujii Masao
Дата:

On 2023/06/08 0:53, Fujii Masao wrote:
> 
> 
> On 2023/06/07 23:25, Mehmet Emin KARAKAŞ wrote:
>> Fixed typo in SQL.
>>
>> Current: ALTER FOREIGN TABLE myschema.distributors OPTIONS (ADD opt1 'value', SET opt2 'value2', DROP opt3
'value3');
>>
>> Fixed: ALTER FOREIGN TABLE myschema.distributors OPTIONS (ADD opt1 'value', SET opt2 'value2', DROP opt3);
>>
>> Drop options do not get a value.
> 
> Thanks for the report! I agree with your findings and the patch looks good to me.
> I will commit the patch barring any objection.

Pushed. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Re: [DOCS] alter_foreign_table.sgml typo

От
Mehmet Emin KARAKAŞ
Дата:
Thank you. 

Fujii Masao <masao.fujii@oss.nttdata.com>, 8 Haz 2023 Per, 14:19 tarihinde şunu yazdı:


On 2023/06/08 0:53, Fujii Masao wrote:
>
>
> On 2023/06/07 23:25, Mehmet Emin KARAKAŞ wrote:
>> Fixed typo in SQL.
>>
>> Current: ALTER FOREIGN TABLE myschema.distributors OPTIONS (ADD opt1 'value', SET opt2 'value2', DROP opt3 'value3');
>>
>> Fixed: ALTER FOREIGN TABLE myschema.distributors OPTIONS (ADD opt1 'value', SET opt2 'value2', DROP opt3);
>>
>> Drop options do not get a value.
>
> Thanks for the report! I agree with your findings and the patch looks good to me.
> I will commit the patch barring any objection.

Pushed. Thanks!

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION


--
MEHMET EMİN KARAKAŞ