Обсуждение: Comment in preptlist.c

Поиск
Список
Период
Сортировка

Comment in preptlist.c

От
Etsuro Fujita
Дата:
While working on something else, I noticed $SUBJECT added by commit 86dc90056:

 * For UPDATE and DELETE queries, the targetlist must also contain "junk"
 * tlist entries needed to allow the executor to identify the rows to be
 * updated or deleted; for example, the ctid of a heap row.  (The planner
 * adds these; they're not in what we receive from the planner/rewriter.)

I think that “planner/rewriter” should be parser/rewriter.  Attached
is a patch for that.

Best regards,
Etsuro Fujita
Вложения

Re: Comment in preptlist.c

От
Richard Guo
Дата:

On Tue, Mar 21, 2023 at 5:41 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
While working on something else, I noticed $SUBJECT added by commit 86dc90056:

 * For UPDATE and DELETE queries, the targetlist must also contain "junk"
 * tlist entries needed to allow the executor to identify the rows to be
 * updated or deleted; for example, the ctid of a heap row.  (The planner
 * adds these; they're not in what we receive from the planner/rewriter.)

I think that “planner/rewriter” should be parser/rewriter.  Attached
is a patch for that.

Yes of course.  It should be parser/rewriter here.

Thanks
Richard

Re: Comment in preptlist.c

От
Tom Lane
Дата:
Etsuro Fujita <etsuro.fujita@gmail.com> writes:
> While working on something else, I noticed $SUBJECT added by commit 86dc90056:
>  * For UPDATE and DELETE queries, the targetlist must also contain "junk"
>  * tlist entries needed to allow the executor to identify the rows to be
>  * updated or deleted; for example, the ctid of a heap row.  (The planner
>  * adds these; they're not in what we receive from the planner/rewriter.)

> I think that “planner/rewriter” should be parser/rewriter.  Attached
> is a patch for that.

Agreed, obviously a thinko :-(

            regards, tom lane

Re: Comment in preptlist.c

От
David Rowley
Дата:
On Tue, 21 Mar 2023 at 22:41, Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> I think that “planner/rewriter” should be parser/rewriter.  Attached
> is a patch for that.

Pushed.

David

Re: Comment in preptlist.c

От
Etsuro Fujita
Дата:
On Wed, Mar 22, 2023 at 4:59 AM David Rowley <dgrowleyml@gmail.com> wrote:
> On Tue, 21 Mar 2023 at 22:41, Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> > I think that “planner/rewriter” should be parser/rewriter.  Attached
> > is a patch for that.
>
> Pushed.

Thanks for picking this up, David!  Thanks for looking, Tom and Richard!

Best regards,
Etsuro Fujita

Re: Comment in preptlist.c

От
David Rowley
Дата:
On Wed, 22 Mar 2023 at 20:40, Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> Thanks for picking this up, David!  Thanks for looking, Tom and Richard!

And now it just clicked with me why Tom left this. Sorry for stepping
on your toes here.

David

Re: Comment in preptlist.c

От
Etsuro Fujita
Дата:
On Wed, Mar 22, 2023 at 4:50 PM David Rowley <dgrowleyml@gmail.com> wrote:
> And now it just clicked with me why Tom left this. Sorry for stepping
> on your toes here.

No problem at all.

Best regards,
Etsuro Fujita