Обсуждение: Quoting issue from ODBC

On 2/7/23 16:10, Brad White wrote:
> Front end: Access 365
> Back end: Postgres 9.4
> (I know, we are in the process of upgrading)
> 
> I'm getting some cases where the SQL sent from MS-Access is failing.
> Looking at the postgres log shows that the field names and table names 
> are not being quoted properly.
> It has been my experience that Access usually does a better job at 
> converting the queries than I would have expected, but not in this instance.
> 
> For example
> 
> Access: connection.Execute "UPDATE [" & strTable & "] SET [" & strTable 
> & "].[InsertFlag] = Null" _
>      & " WHERE ((([" & strTable & "].[InsertFlag])=" & lngCurrUID & 
> "));", , adCmdText Or adExecuteNoRecords
> Note that InsertFlag is bracketed the same way in both instances.
> 
> PSQL: UPDATE "public"."Orders" SET InsertFlag=NULL  WHERE ("InsertFlag" 
> = 166 )
> Note that InsertFlag is quoted once but not the other time.
> Of course this gives the error: column "insertflag" of relation "Orders" 
> does not exist at character 35.
> 
> Looks like I have about 16 unique instances of statements not being 
> quoted correctly resulting in over 500 errors in the log for today.

Where these preexisting queries or where they created today?

If preexisting have there been any changes to the software stack since 
yesterday?

If new how where the queries generated?

> 
> Any suggestions on where to look?
> 
> Thanks,
> Brad.

-- 
Adrian Klaver
adrian.klaver@aklaver.com

On Tue, Feb 7, 2023 at 5:20 PM Brad White <b55white@gmail.com> wrote:

For example, this is the literal code in VBA

Access: connection.Execute "UPDATE [" & strTable & "] SET [" & strTable & "].[InsertFlag] = Null" _

    & " WHERE ((([" & strTable & "].[InsertFlag])=" & lngCurrUID & "));", , adCmdText Or adExecuteNoRecords

Note that InsertFlag is bracketed the same way in both instances.

PSQL: UPDATE "public"."Orders" SET InsertFlag=NULL  WHERE ("InsertFlag" = 166 )

Note that InsertFlag is quoted once but not the other time.

Of course this gives the error: column "insertflag" of relation "Orders" does not exist at character 35.

Either VBA is doing some query munging or that concatenated string isn't the one that is producing the error.  Which suggests that maybe you have a string somewhere that is not written correctly that need to be fixed so it doesn't produce this error.

David J.

update foo set foo.id = something;

On 2/7/23 16:10, Brad White wrote:

Front end: Access 365
Back end: Postgres 9.4
(I know, we are in the process of upgrading)

I'm getting some cases where the SQL sent from MS-Access is failing.
Looking at the postgres log shows that the field names and table names are not being quoted properly.
It has been my experience that Access usually does a better job at converting the queries than I would have expected, but not in this instance.

For example

Access: connection.Execute "UPDATE [" & strTable & "] SET [" & strTable & "].[InsertFlag] = Null" _
     & " WHERE ((([" & strTable & "].[InsertFlag])=" & lngCurrUID & "));", , adCmdText Or adExecuteNoRecords
Note that InsertFlag is bracketed the same way in both instances.

PSQL: UPDATE "public"."Orders" SET InsertFlag=NULL  WHERE ("InsertFlag" = 166 )
Note that InsertFlag is quoted once but not the other time.
Of course this gives the error: column "insertflag" of relation "Orders" does not exist at character 35.

Looks like I have about 16 unique instances of statements not being quoted correctly resulting in over 500 errors in the log for today.

Where these preexisting queries or where they created today?

These queries are decades old but I don't view this log file very often, so I don't know how long.

I'll review when I get back on site Thursday and see if I can find any users that are not getting the error or when it started.

Any suggestions on where to look?

Thanks,
Brad.

On 2/9/23 14:43, Brad White wrote:
> On Tue, Feb 7, 2023 at 10:20 PM Brad White <b55white@gmail.com 
> <mailto:b55white@gmail.com>> wrote:
> 
>     On 2/7/2023 6:19 PM, Adrian Klaver wrote:
>>     On 2/7/23 16:10, Brad White wrote:
>>>     Front end: Access 365
>>>     Back end: Postgres 9.4
>>>     (I know, we are in the process of upgrading)
>>>
>>>     I'm getting some cases where the SQL sent from MS-Access is failing.
>>>     Looking at the postgres log shows that the field names and table
>>>     names are not being quoted properly.
>>>     It has been my experience that Access usually does a better job
>>>     at converting the queries than I would have expected, but not in
>>>     this instance.
>>>
>>>     For example
>>>
>>>     Access: connection.Execute "UPDATE [" & strTable & "] SET [" &
>>>     strTable & "].[InsertFlag] = Null" _
>>>          & " WHERE ((([" & strTable & "].[InsertFlag])=" & lngCurrUID
>>>     & "));", , adCmdText Or adExecuteNoRecords
>>>     Note that InsertFlag is bracketed the same way in both instances.
>>>
>>>     PSQL: UPDATE "public"."Orders" SET InsertFlag=NULL  WHERE
>>>     ("InsertFlag" = 166 )
>>>     Note that InsertFlag is quoted once but not the other time.
>>>     Of course this gives the error: column "insertflag" of relation
>>>     "Orders" does not exist at character 35.
>>>
>>>     Looks like I have about 16 unique instances of statements not
>>>     being quoted correctly resulting in over 500 errors in the log
>>>     for today.
>>
>>     Where these preexisting queries or where they created today?
> 
>     These queries are decades old but I don't view this log file very
>     often, so I don't know how long.
> 
>     I'll review when I get back on site Thursday and see if I can find
>     any users that are not getting the error or when it started.
> 
>>
>>>
>>>     Any suggestions on where to look?
>>>
>>>     Thanks,
>>>     Brad.
> 
> Back in the office today and I note that all of the fields that are 
> getting the issue are the target field in an UPDATE statement.
> All the other tables and field names are quoted correctly.
> 
> I suspect an ODBC driver bug.  Is there a better place to report those?
> 
> Driver: PostgreSQL Unicode
> Filename: PSQLODBC35W.DLL
> Version: 13.02.00
> ReleaseDate: 9/22/2021

https://www.postgresql.org/list/pgsql-odbc/

> 
> On the other hand, the app updates things all the time. Only about 12 of 
> the update statements are ending up in the log. Still looking for the 
> common denominator in how those statements are called.


So how the successful UPDATE's called?

Are the successful UPDATES's on the same tables and columns?

 From your subsequent post:

"Going back to early 2020, I don't have any logs that don't have these 
errors, so it is not a recent change."

Are these UPDATE's actually necessary?

In other words has nobody noticed a problem with the data over that time 
frame?



-- 
Adrian Klaver
adrian.klaver@aklaver.com

On 2/14/23 14:58, Brad White wrote:
>  > Are these UPDATE's actually necessary?
>  > In other words has nobody noticed a problem with the data over that 
> time frame?
> 
> I don't know what to make of it.
> I had the same question you did.
> 
> I now have proof that these hundreds of errors are not an issue.
> The postgres logs in pg_log clearly show an error, but the errors never 
> show up in the Access log.

Then either:

1) They are not coming from Access.

2) Or indirectly from Access, which kicks off some other code that is 
not logged.

In either case they seem to be surplus to requirements. In other words 
cruft that is not actually relevant to the application.

> That means that Access didn't get an error back.
> Further, I have evidence that the values are actually getting updated.
> The financial balances are all correct.
> Issues that were closed are all closed, etc.
> Even though the Access log says the statement was only run once and 
> Postgres says ERROR, I see no other evidence of it.
> I can't fathom how that can happen.
> 
> ¯\_(ツ)_/¯
> 
> On the other hand, there are some real errors in the log. I'll put that 
> in another post.
> 
> Brad

-- 
Adrian Klaver
adrian.klaver@aklaver.com