Обсуждение: jsonlog cursor_position type is wrong.

> Hi.
> 
> PostgreSQL document In "Table 20.3. Keys and Values of JSON Log Entries",
> "Type" in cursor_position should be "number", not "Sting".
> https://www.postgresql.org/docs/current/runtime-config-logging.html#RUNTIME-CONFIG-LOGGING-JSONLOG-KEYS-VALUES

Yeah, that's a typo. Patch attached.

Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 703f6d5a7f..724c832308 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -7794,7 +7794,7 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv;
         </row>
         <row>
          <entry><literal>cursor_position</literal></entry>
-         <entry>string</entry>
+         <entry>number</entry>
          <entry>Cursor index into query string</entry>
         </row>
         <row>

Tatsuo Ishii <ishii@sraoss.co.jp> writes:
>> PostgreSQL document In "Table 20.3. Keys and Values of JSON Log Entries",
>> "Type" in cursor_position should be "number", not "Sting".
>> https://www.postgresql.org/docs/current/runtime-config-logging.html#RUNTIME-CONFIG-LOGGING-JSONLOG-KEYS-VALUES

> Yeah, that's a typo. Patch attached.

Shouldn't it be "integer"?

            regards, tom lane

On Mon, Oct 24, 2022 at 12:53:26AM -0400, Tom Lane wrote:
> Tatsuo Ishii <ishii@sraoss.co.jp> writes:
>> Yeah, that's a typo. Patch attached.

Thanks, that's wrong :/

> Shouldn't it be "integer"?

When it comes down to the data types of a JSON object, these are
referred as "number", as these can be either integers or floating
points.  See:
https://www.w3schools.com/js/js_json_datatypes.asp
--
Michael

On Mon, Oct 24, 2022 at 02:04:48PM +0900, Michael Paquier wrote:
> Thanks, that's wrong :/

Anyway, this one is on me, so applied.  Thanks for the patch and the
report!
--
Michael

> On Mon, Oct 24, 2022 at 02:04:48PM +0900, Michael Paquier wrote:
>> Thanks, that's wrong :/
> 
> Anyway, this one is on me, so applied.  Thanks for the patch and the
> report!

Thank you!
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp