Обсуждение: Removed unused param isSlice of function transformAssignmentSubscripts

Поиск
Список
Период
Сортировка

Removed unused param isSlice of function transformAssignmentSubscripts

От
Zhang Mingli
Дата:
Hi, 


Param isSlice was once used to identity targetTypeId for transformAssignmentIndirection.

In commit c7aba7c14e, the evaluation was pushed down to transformContainerSubscripts.

No need to keep isSlice around transformAssignmentSubscripts.

Attach a patch to remove it.

Regards,
Zhang Mingli
Вложения

Re: Removed unused param isSlice of function transformAssignmentSubscripts

От
Richard Guo
Дата:

On Tue, Sep 13, 2022 at 11:35 AM Zhang Mingli <zmlpostgres@gmail.com> wrote:
Param isSlice was once used to identity targetTypeId for transformAssignmentIndirection.

In commit c7aba7c14e, the evaluation was pushed down to transformContainerSubscripts.

No need to keep isSlice around transformAssignmentSubscripts.

Attach a patch to remove it.
 
+1. Good catch.

Thanks
Richard

Re: Removed unused param isSlice of function transformAssignmentSubscripts

От
Michael Paquier
Дата:
On Tue, Sep 13, 2022 at 03:20:01PM +0800, Richard Guo wrote:
> +1. Good catch.

Yes, you are right that this comes from c7aba7c that has changed the
transform logic and the check on slicing support, and this makes the
code easier to follow.  So, applied.
--
Michael
Вложения