Обсуждение: pgsql: pg_dump: Dump colliculocale
pg_dump: Dump colliculocale This was forgotten when the new column was introduced. Author: Marina Polyakova <m.polyakova@postgrespro.ru> Reviewed-by: Julien Rouhaud <rjuju123@gmail.com> Discussion: https://www.postgresql.org/message-id/7ad26354e75259f59c4a6c6997b8ee32%40postgrespro.ru Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/396d348b046c6b7e5dc83158c4c1df1377a1d2ef Modified Files -------------- src/bin/pg_dump/Makefile | 1 + src/bin/pg_dump/pg_dump.c | 50 +++++++++++++++++++++++++++++++++------- src/bin/pg_dump/t/002_pg_dump.pl | 28 +++++++++++++++++++++- 3 files changed, 70 insertions(+), 9 deletions(-)
Peter Eisentraut <peter@eisentraut.org> writes:
> pg_dump: Dump colliculocale
The *BSD buildfarm members don't seem too happy with the new test case.
regards, tom lane
I wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> pg_dump: Dump colliculocale
> The *BSD buildfarm members don't seem too happy with the new test case.
Not just those. I found that on my RHEL8 box, the new pg_dump
test passes if the environment has LANG=en_US.utf8, and fails
if LANG=C.
regards, tom lane
Hello! Sorry for that, diff_fix_002_pg_dump.patch fixes this issue for me... On 2022-08-25 04:46, Tom Lane wrote: > I wrote: >> The *BSD buildfarm members don't seem too happy with the new test >> case. > > Not just those. I found that on my RHEL8 box, the new pg_dump > test passes if the environment has LANG=en_US.utf8, and fails > if LANG=C. > > regards, tom lane -- Marina Polyakova Postgres Professional: http://www.postgrespro.com The Russian Postgres Company
Вложения
More precisely, diff_fix_002_pg_dump_v2.patch... On 2022-08-25 07:50, Marina Polyakova wrote: > Hello! > > Sorry for that, diff_fix_002_pg_dump.patch fixes this issue for me... > > On 2022-08-25 04:46, Tom Lane wrote: >> I wrote: >>> The *BSD buildfarm members don't seem too happy with the new test >>> case. >> >> Not just those. I found that on my RHEL8 box, the new pg_dump >> test passes if the environment has LANG=en_US.utf8, and fails >> if LANG=C. >> >> regards, tom lane -- Marina Polyakova Postgres Professional: http://www.postgrespro.com The Russian Postgres Company
Вложения
Thanks, I had already fixed it. On 25.08.22 07:03, Marina Polyakova wrote: > More precisely, diff_fix_002_pg_dump_v2.patch... > > On 2022-08-25 07:50, Marina Polyakova wrote: >> Hello! >> >> Sorry for that, diff_fix_002_pg_dump.patch fixes this issue for me... >> >> On 2022-08-25 04:46, Tom Lane wrote: >>> I wrote: >>>> The *BSD buildfarm members don't seem too happy with the new test case. >>> >>> Not just those. I found that on my RHEL8 box, the new pg_dump >>> test passes if the environment has LANG=en_US.utf8, and fails >>> if LANG=C. >>> >>> regards, tom lane >