Обсуждение: Add PGCAC donation option
The attached patch adds an option to the donations page to allow people to donate to PGCAC, the NPO responsible for managing and protecting project domain names and trademarks etc.
--
Any comments before I commit?
Вложения
> On 30 Jun 2022, at 10:43, Dave Page <dpage@pgadmin.org> wrote: > Any comments before I commit? +PostgreSQL Core Team to manage and protect key project assets such domain names +and trademarks.</p> Shouldn't that be "such as domain names"? +<input class="btn btn-primary" type="submit" name="submit" value="Donate to PGCAC" /> The other donation buttons are links to pages about donation, and not direct actions (but I understand why this is). Maybe it should say "Donate to PGCAC by PayPal"? -- Daniel Gustafsson https://vmware.com/
On Thu, Jun 30, 2022 at 11:29 AM Daniel Gustafsson <daniel@yesql.se> wrote:
> On 30 Jun 2022, at 10:43, Dave Page <dpage@pgadmin.org> wrote:
> Any comments before I commit?
+PostgreSQL Core Team to manage and protect key project assets such domain names
+and trademarks.</p>
Shouldn't that be "such as domain names"?
+<input class="btn btn-primary" type="submit" name="submit" value="Donate to PGCAC" />
The other donation buttons are links to pages about donation, and not direct
actions (but I understand why this is). Maybe it should say "Donate to PGCAC
by PayPal"?
+1. I definitely don't think we should make a form-post-to-paypal directly without saying it's PayPal.
Even more, I think it'd be better to lin kit to a page on the cac homepage which has the link -- both so it works the same as the others, but also so that we (pgweb) don't end up with "ownership" of the actual paypal code in the form.
And if needed, +1 for adding the button in general -- I think the only reason we haven't had a button for pgcac before is that pgcac has asked for there not to be one :)
On Thu, 30 Jun 2022 at 10:29, Daniel Gustafsson <daniel@yesql.se> wrote:
> On 30 Jun 2022, at 10:43, Dave Page <dpage@pgadmin.org> wrote:
> Any comments before I commit?
+PostgreSQL Core Team to manage and protect key project assets such domain names
+and trademarks.</p>
Shouldn't that be "such as domain names"?
Well spotted.
+<input class="btn btn-primary" type="submit" name="submit" value="Donate to PGCAC" />
The other donation buttons are links to pages about donation, and not direct
actions (but I understand why this is). Maybe it should say "Donate to PGCAC
by PayPal"?
I'm hesitant to put that as we know it puts some people off because they think they need a PayPal account, when in fact they actually don't because the page it takes them too offers a direct card payment option as well.
Вложения
On Thu, 30 Jun 2022 at 10:52, Magnus Hagander <magnus@hagander.net> wrote:
On Thu, Jun 30, 2022 at 11:29 AM Daniel Gustafsson <daniel@yesql.se> wrote:> On 30 Jun 2022, at 10:43, Dave Page <dpage@pgadmin.org> wrote:
> Any comments before I commit?
+PostgreSQL Core Team to manage and protect key project assets such domain names
+and trademarks.</p>
Shouldn't that be "such as domain names"?
+<input class="btn btn-primary" type="submit" name="submit" value="Donate to PGCAC" />
The other donation buttons are links to pages about donation, and not direct
actions (but I understand why this is). Maybe it should say "Donate to PGCAC
by PayPal"?+1. I definitely don't think we should make a form-post-to-paypal directly without saying it's PayPal.Even more, I think it'd be better to lin kit to a page on the cac homepage which has the link -- both so it works the same as the others, but also so that we (pgweb) don't end up with "ownership" of the actual paypal code in the form.
That's not entirely unreasonable. Let me add a page to the CAC site, then I'll update the patch.
And if needed, +1 for adding the button in general -- I think the only reason we haven't had a button for pgcac before is that pgcac has asked for there not to be one :)--
On Thu, 30 Jun 2022 at 10:54, Dave Page <dpage@pgadmin.org> wrote:
On Thu, 30 Jun 2022 at 10:52, Magnus Hagander <magnus@hagander.net> wrote:On Thu, Jun 30, 2022 at 11:29 AM Daniel Gustafsson <daniel@yesql.se> wrote:> On 30 Jun 2022, at 10:43, Dave Page <dpage@pgadmin.org> wrote:
> Any comments before I commit?
+PostgreSQL Core Team to manage and protect key project assets such domain names
+and trademarks.</p>
Shouldn't that be "such as domain names"?
+<input class="btn btn-primary" type="submit" name="submit" value="Donate to PGCAC" />
The other donation buttons are links to pages about donation, and not direct
actions (but I understand why this is). Maybe it should say "Donate to PGCAC
by PayPal"?+1. I definitely don't think we should make a form-post-to-paypal directly without saying it's PayPal.Even more, I think it'd be better to lin kit to a page on the cac homepage which has the link -- both so it works the same as the others, but also so that we (pgweb) don't end up with "ownership" of the actual paypal code in the form.That's not entirely unreasonable. Let me add a page to the CAC site, then I'll update the patch.
And here's an updated patch with a link to https://www.postgres.ca/donate instead of direct to PayPal.
Вложения
> On 30 Jun 2022, at 12:15, Dave Page <dpage@pgadmin.org> wrote: > And here's an updated patch with a link to https://www.postgres.ca/donate <https://www.postgres.ca/donate> instead of directto PayPal. +PostgreSQL Core Team to manage and protect key project assets such domain names +and trademarks.</p> Still needs to be fixed wih "such as", other than that +1. -- Daniel Gustafsson https://vmware.com/
On 6/30/22 6:17 AM, Daniel Gustafsson wrote: >> On 30 Jun 2022, at 12:15, Dave Page <dpage@pgadmin.org> wrote: > >> And here's an updated patch with a link to https://www.postgres.ca/donate <https://www.postgres.ca/donate> instead ofdirect to PayPal. > > +PostgreSQL Core Team to manage and protect key project assets such domain names > +and trademarks.</p> > > Still needs to be fixed wih "such as", other than that +1. Formatted the patch, included Daniel's feedback, and pushed. Jonathan
Вложения
On Fri, 1 Jul 2022 at 03:32, Jonathan S. Katz <jkatz@postgresql.org> wrote:
On 6/30/22 6:17 AM, Daniel Gustafsson wrote:
>> On 30 Jun 2022, at 12:15, Dave Page <dpage@pgadmin.org> wrote:
>
>> And here's an updated patch with a link to https://www.postgres.ca/donate <https://www.postgres.ca/donate> instead of direct to PayPal.
>
> +PostgreSQL Core Team to manage and protect key project assets such domain names
> +and trademarks.</p>
>
> Still needs to be fixed wih "such as", other than that +1.
Formatted the patch, included Daniel's feedback, and pushed.
Thanks!