Обсуждение: [PATCH 1/2] pgarchives: Add missing authentication backend to settings.py

Поиск
Список
Период
Сортировка

[PATCH 1/2] pgarchives: Add missing authentication backend to settings.py

От
Célestin Matte
Дата:
Hello,

Authentication when using private archives in pgarchives is broken with current settings.py file.
This first patch add a missing backend in settings.py, without which sessions aren't registered and users get
redirectedindefinitely.
 
In the second patch of this series, I add missing parameters for configuring PGAUTH, copying the ones from pglister.

Cheers,
-- 
Célestin Matte
Вложения

[PATCH 2/2] pgarchives: Add missing example pgauth config in settings.py

От
Célestin Matte
Дата:
> In the second patch of this series, I add missing parameters for configuring PGAUTH, copying the ones from
pglister.--
 
Célestin Matte
Вложения

Re: [PATCH 1/2] pgarchives: Add missing authentication backend to settings.py

От
Magnus Hagander
Дата:
On Thu, Oct 28, 2021 at 7:42 PM Célestin Matte <celestin.matte@cmatte.me> wrote:
>
> Hello,
>
> Authentication when using private archives in pgarchives is broken with current settings.py file.
> This first patch add a missing backend in settings.py, without which sessions aren't registered and users get
redirectedindefinitely. 
> In the second patch of this series, I add missing parameters for configuring PGAUTH, copying the ones from pglister.

Yeah, technically it's configured to use django auth but then we
override that elsewhere.  It might be worthwhile to remove those
hardcoded redirects and make it possible to use the system with the
built in django auth. But until someone does that, I agree that
putting a working value into AUTHENTICATION_BACKEND is definitely
better.

And also the example file that was in your patch #2.

Both patches squashed and applied. Thanks!

--
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/