Обсуждение: pgsql: Add support for LZ4 build in MSVC scripts

Поиск
Список
Период
Сортировка

pgsql: Add support for LZ4 build in MSVC scripts

От
Michael Paquier
Дата:
Add support for LZ4 build in MSVC scripts

Since its introduction in bbe0a81, compression of table data supports
LZ4, but nothing had been done within the MSVC scripts to allow users to
build the code with this library.

This commit closes the gap by extending the MSVC scripts to be able to
build optionally with LZ4.  Getting libraries that can be used for
compilation and execution is possible as LZ4 can be compiled down to
MSVC 2010 using its source tarball.  MinGW may require extra efforts to
be able to work, and I have been able to test this only with MSVC, still
this is better than nothing to give users a way to test the feature on
Windows.

Author: Dilip Kumar
Reviewed-by: Michael Paquier
Discussion: https://postgr.es/m/YJPdNeF68XpwDDki@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9ca40dcd4d0cad43d95a9a253fafaa9a9ba7de24

Modified Files
--------------
doc/src/sgml/install-windows.sgml | 10 ++++++++++
src/tools/msvc/Solution.pm        | 12 ++++++++++++
src/tools/msvc/config_default.pl  |  1 +
3 files changed, 23 insertions(+)


Re: pgsql: Add support for LZ4 build in MSVC scripts

От
Andrew Dunstan
Дата:
On 5/10/21 9:44 PM, Michael Paquier wrote:
> Add support for LZ4 build in MSVC scripts
>
> Since its introduction in bbe0a81, compression of table data supports
> LZ4, but nothing had been done within the MSVC scripts to allow users to
> build the code with this library.
>
> This commit closes the gap by extending the MSVC scripts to be able to
> build optionally with LZ4.  Getting libraries that can be used for
> compilation and execution is possible as LZ4 can be compiled down to
> MSVC 2010 using its source tarball.  MinGW may require extra efforts to
> be able to work, and I have been able to test this only with MSVC, still
> this is better than nothing to give users a way to test the feature on
> Windows.


I don't think there's anything to do here. On Msys2 I think you can just
do 'pacman -S mingw64/mingw-w64-x86_64-lz4' and configure as normal.


cheers


andrew



--
Andrew Dunstan
EDB: https://www.enterprisedb.com




Re: pgsql: Add support for LZ4 build in MSVC scripts

От
Michael Paquier
Дата:
On Tue, May 11, 2021 at 08:49:35PM -0400, Andrew Dunstan wrote:
> I don't think there's anything to do here. On Msys2 I think you can just
> do 'pacman -S mingw64/mingw-w64-x86_64-lz4' and configure as normal.

Good to know.  Thanks!
--
Michael

Вложения