Обсуждение: pgsql: pg_dump: Fix dumping of inherited generated columns

Поиск
Список
Период
Сортировка

pgsql: pg_dump: Fix dumping of inherited generated columns

От
Peter Eisentraut
Дата:
pg_dump: Fix dumping of inherited generated columns

Generation expressions of generated columns are always inherited, so
there is no need to set them separately in child tables, and there is
no syntax to do so either.  The code previously used the code paths
for the handling of default values, for which different rules apply;
in particular it might want to set a default value explicitly for an
inherited column.  This resulted in unrestorable dumps.  For generated
columns, just skip them in inherited tables.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/15830.1575468847%40sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0bf83648a52df96f7c8677edbbdf141bfa0cf32b

Modified Files
--------------
src/bin/pg_dump/common.c         | 31 +++++++++++++++++++++------
src/bin/pg_dump/pg_dump.c        | 37 +++++++++++++++++++++++++++-----
src/bin/pg_dump/t/002_pg_dump.pl | 46 ++++++++++++++++++++++++++++++++++++++++
3 files changed, 102 insertions(+), 12 deletions(-)