Обсуждение: [pgAdmin][RM-6120]: Adding/updating user should not allow to add an older date in account expires.

Hi Team,

Please find the attached patch for RM-6120: Adding/updating user should not allow to add an older date in account expires.

Added UI validation if a user enters the account expiration date manually.

--

Thanks & Regards,

Nikhil Mohite

Software Engineer.

EDB Postgres

Mob.No: +91-7798364578.

Hi Nikhil

On Thu, Jan 14, 2021 at 2:38 PM Dave Page <dpage@pgadmin.org> wrote:

On Thu, Jan 14, 2021 at 8:18 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Thanks, patch applied.

On Thu, Jan 14, 2021 at 11:28 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:

Hi Team,

Please find the attached patch for RM-6120: Adding/updating user should not allow to add an older date in account expires.

Added UI validation if a user enters the account expiration date manually.

I think this needs to be reverted (and the UI fixed to allow an older date to be selected).

   Please fixed as suggested by Dave and send the patch. I'll update the RM 

Selecting a past expiry date is a perfectly valid way to create an account that is effectively locked, for example, to allow pre-creation of roles for staff that are yet to join.

PostgreSQL doesn't prevent this - why should we?

--  

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com

--

Thanks & Regards

Akshay Joshi

pgAdmin Hacker | Principal Software Architect

EDB Postgres

Mobile: +91 976-788-8246

Hi Akshay,

Please find the updated patch, updated UI to allow users to select an older date for the account expires.

Regards,

Nikhil Mohite.

On Thu, Jan 14, 2021 at 2:52 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Nikhil

On Thu, Jan 14, 2021 at 2:38 PM Dave Page <dpage@pgadmin.org> wrote:

On Thu, Jan 14, 2021 at 8:18 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Thanks, patch applied.

On Thu, Jan 14, 2021 at 11:28 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:

Hi Team,

Please find the attached patch for RM-6120: Adding/updating user should not allow to add an older date in account expires.

Added UI validation if a user enters the account expiration date manually.

I think this needs to be reverted (and the UI fixed to allow an older date to be selected).

   Please fixed as suggested by Dave and send the patch. I'll update the RM 

Selecting a past expiry date is a perfectly valid way to create an account that is effectively locked, for example, to allow pre-creation of roles for staff that are yet to join.

PostgreSQL doesn't prevent this - why should we?

--  

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com

--

Thanks & Regards

Akshay Joshi

pgAdmin Hacker | Principal Software Architect

EDB Postgres

Mobile: +91 976-788-8246