Обсуждение: [pgAdmin][RM5571] Expression in exclusion constraint is misinterpreted and quoted as column name by mistake

Hi Hackers,

Attached is the patch to add support for expressions in exclusion constraints. This also fixes the SQL generated for existing expression based constraints also.

Docs updated and test cases enhanced.

Please review.

--

Thanks,

Aditya Toshniwal

pgAdmin hacker | Sr. Software Engineer | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

Thanks, patch applied.

On Wed, Dec 23, 2020 at 6:10 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Attached is the patch to add support for expressions in exclusion constraints. This also fixes the SQL generated for existing expression based constraints also.

Docs updated and test cases enhanced.

Please review.

--

Thanks,

Aditya Toshniwal

pgAdmin hacker | Sr. Software Engineer | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

--

Thanks & Regards

Akshay Joshi

pgAdmin Hacker | Principal Software Architect

EDB Postgres

Mobile: +91 976-788-8246

Hi,

Attached patch fixes the failing RESQL test cases.

On Thu, Dec 24, 2020 at 1:15 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Thanks, patch applied.

On Wed, Dec 23, 2020 at 6:10 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Attached is the patch to add support for expressions in exclusion constraints. This also fixes the SQL generated for existing expression based constraints also.

Docs updated and test cases enhanced.

Please review.

--

Thanks,

Aditya Toshniwal

pgAdmin hacker | Sr. Software Engineer | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

--

Thanks & Regards

Akshay Joshi

pgAdmin Hacker | Principal Software Architect

EDB Postgres

Mobile: +91 976-788-8246

--

Thanks,

Aditya Toshniwal

pgAdmin hacker | Sr. Software Engineer | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

Thanks, patch applied.

On Thu, Dec 24, 2020 at 1:46 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi,

Attached patch fixes the failing RESQL test cases.

On Thu, Dec 24, 2020 at 1:15 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Thanks, patch applied.

On Wed, Dec 23, 2020 at 6:10 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Attached is the patch to add support for expressions in exclusion constraints. This also fixes the SQL generated for existing expression based constraints also.

Docs updated and test cases enhanced.

Please review.

--

Thanks,

Aditya Toshniwal

pgAdmin hacker | Sr. Software Engineer | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

--

Thanks & Regards

Akshay Joshi

pgAdmin Hacker | Principal Software Architect

EDB Postgres

Mobile: +91 976-788-8246

--

Thanks,

Aditya Toshniwal

pgAdmin hacker | Sr. Software Engineer | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

--

Thanks & Regards

Akshay Joshi

pgAdmin Hacker | Principal Software Architect

EDB Postgres

Mobile: +91 976-788-8246

Hi Hackers,

The changes in CREATE TABLE sql were missed. Attached patch adds the changes.

On Thu, Dec 24, 2020 at 3:02 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Thanks, patch applied.

On Thu, Dec 24, 2020 at 1:46 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi,

Attached patch fixes the failing RESQL test cases.

On Thu, Dec 24, 2020 at 1:15 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Thanks, patch applied.

On Wed, Dec 23, 2020 at 6:10 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Attached is the patch to add support for expressions in exclusion constraints. This also fixes the SQL generated for existing expression based constraints also.

Docs updated and test cases enhanced.

Please review.

--

Thanks,

Aditya Toshniwal

pgAdmin hacker | Sr. Software Engineer | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

--

Thanks & Regards

Akshay Joshi

pgAdmin Hacker | Principal Software Architect

EDB Postgres

Mobile: +91 976-788-8246

--

Thanks,

Aditya Toshniwal

pgAdmin hacker | Sr. Software Engineer | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

--

Thanks & Regards

Akshay Joshi

pgAdmin Hacker | Principal Software Architect

EDB Postgres

Mobile: +91 976-788-8246

--

Thanks,

Aditya Toshniwal

pgAdmin hacker | Sr. Software Engineer | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"