Обсуждение: [pgAdmin][SonarQube] Replace the generic exception class with a more specific one

Поиск
Список
Период
Сортировка

[pgAdmin][SonarQube] Replace the generic exception class with a more specific one

От
Aditya Toshniwal
Дата:
Hi Hackers,

Attached is the patch to replace the generic exception class with a newly added ExecuteError class for all the places where error occurs when a SQL is executed.
This fixes around 34 issues.

Please review.
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Вложения

Re: [pgAdmin][SonarQube] Replace the generic exception class with a more specific one

От
Akshay Joshi
Дата:
Thanks, patch applied.

On Wed, Aug 5, 2020 at 11:09 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to replace the generic exception class with a newly added ExecuteError class for all the places where error occurs when a SQL is executed.
This fixes around 34 issues.

Please review.
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Re: [pgAdmin][SonarQube] Replace the generic exception class with a more specific one

От
Aditya Toshniwal
Дата:
Hi Hackers,

Attached is the followup patch to fix all the remaining issues (around 30) related to replacing the generic exception class with more specific ones.
Please review.

On Wed, Aug 5, 2020 at 12:42 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.

On Wed, Aug 5, 2020 at 11:09 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to replace the generic exception class with a newly added ExecuteError class for all the places where error occurs when a SQL is executed.
This fixes around 34 issues.

Please review.
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Вложения

Re: [pgAdmin][SonarQube] Replace the generic exception class with a more specific one

От
Akshay Joshi
Дата:
Thanks, patch applied.

On Fri, Aug 7, 2020 at 11:36 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the followup patch to fix all the remaining issues (around 30) related to replacing the generic exception class with more specific ones.
Please review.

On Wed, Aug 5, 2020 at 12:42 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.

On Wed, Aug 5, 2020 at 11:09 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to replace the generic exception class with a newly added ExecuteError class for all the places where error occurs when a SQL is executed.
This fixes around 34 issues.

Please review.
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246