Обсуждение: Update InsertPgAttributeTuple comment to match new signature

Поиск
Список
Период
Сортировка

Update InsertPgAttributeTuple comment to match new signature

От
Daniel Gustafsson
Дата:
The comment for InsertPgAttributeTuple no longer, since 911e702077037996, match
reality as attoptions isn't always initialized to NULL.  The attached removes
mention of attoptions, and updates the list of always-NULL attributes to match
what the code does (the git history didn't provide rationale for why they were
omitted so it seemed like an oversight).

cheers ./daniel


Вложения

Re: Update InsertPgAttributeTuple comment to match new signature

От
Michael Paquier
Дата:
On Mon, Jun 22, 2020 at 04:27:18PM +0200, Daniel Gustafsson wrote:
> The comment for InsertPgAttributeTuple no longer, since 911e702077037996, match
> reality as attoptions isn't always initialized to NULL.  The attached removes
> mention of attoptions, and updates the list of always-NULL attributes to match
> what the code does (the git history didn't provide rationale for why they were
> omitted so it seemed like an oversight).

Looks right to me, good catch.  I'll apply that tomorrow my time
except if there are any objections in-between.
--
Michael

Вложения

Re: Update InsertPgAttributeTuple comment to match new signature

От
Michael Paquier
Дата:
On Tue, Jun 23, 2020 at 02:31:05PM +0900, Michael Paquier wrote:
> Looks right to me, good catch.  I'll apply that tomorrow my time
> except if there are any objections in-between.

And done.
--
Michael

Вложения