Обсуждение: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checks shouldnot be inverted, Comma operator should not be used)
Hi Hackers,
Please find patch fixing sonarqube issues related to below rules -
1.Boolean checks should not be inverted,
2.Comma operator should not be used,
3.Arguments to built-in functions should match documented types,
4.Redundant pairs of parentheses should be removed,
Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation
Phone: +91-9741705709
Phone: +91-9741705709
Вложения
Hi Yogesh
After applying your patch a new sonarqube issue has been found "Change this argument to the documented type: Number." in sqleditor_utils.js
Please fix that and resend the patch.
On Mon, Jun 22, 2020 at 4:36 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi Hackers,Please find patch fixing sonarqube issues related to below rules -1.Boolean checks should not be inverted,2.Comma operator should not be used,3.Arguments to built-in functions should match documented types,4.Redundant pairs of parentheses should be removed,Thanks,Yogesh MahajanQA - TeamEnterpriseDB Corporation
Phone: +91-9741705709
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Hi,
Please find an updated patch.
Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation
Phone: +91-9741705709
Phone: +91-9741705709
On Wed, Jun 24, 2020 at 12:31 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi YogeshAfter applying your patch a new sonarqube issue has been found "Change this argument to the documented type: Number." in sqleditor_utils.jsPlease fix that and resend the patch.On Mon, Jun 22, 2020 at 4:36 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:Hi Hackers,Please find patch fixing sonarqube issues related to below rules -1.Boolean checks should not be inverted,2.Comma operator should not be used,3.Arguments to built-in functions should match documented types,4.Redundant pairs of parentheses should be removed,Thanks,Yogesh MahajanQA - TeamEnterpriseDB Corporation
Phone: +91-9741705709--Thanks & RegardsAkshay JoshiSr. Software ArchitectEnterpriseDB Software India Private LimitedMobile: +91 976-788-8246
Вложения
Hi Yogesh
Jasmin tests are failing, please fix and resend the patch.
On Thu, Jun 25, 2020 at 11:52 AM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi,Please find an updated patch.Thanks,Yogesh MahajanQA - TeamEnterpriseDB Corporation
Phone: +91-9741705709On Wed, Jun 24, 2020 at 12:31 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi YogeshAfter applying your patch a new sonarqube issue has been found "Change this argument to the documented type: Number." in sqleditor_utils.jsPlease fix that and resend the patch.On Mon, Jun 22, 2020 at 4:36 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:Hi Hackers,Please find patch fixing sonarqube issues related to below rules -1.Boolean checks should not be inverted,2.Comma operator should not be used,3.Arguments to built-in functions should match documented types,4.Redundant pairs of parentheses should be removed,Thanks,Yogesh MahajanQA - TeamEnterpriseDB Corporation
Phone: +91-9741705709--Thanks & RegardsAkshay JoshiSr. Software ArchitectEnterpriseDB Software India Private LimitedMobile: +91 976-788-8246
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Hi,
Please find an updated patch.
Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation
Phone: +91-9741705709
Phone: +91-9741705709
On Thu, Jun 25, 2020 at 12:26 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi YogeshJasmin tests are failing, please fix and resend the patch.On Thu, Jun 25, 2020 at 11:52 AM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:Hi,Please find an updated patch.Thanks,Yogesh MahajanQA - TeamEnterpriseDB Corporation
Phone: +91-9741705709On Wed, Jun 24, 2020 at 12:31 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi YogeshAfter applying your patch a new sonarqube issue has been found "Change this argument to the documented type: Number." in sqleditor_utils.jsPlease fix that and resend the patch.On Mon, Jun 22, 2020 at 4:36 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:Hi Hackers,Please find patch fixing sonarqube issues related to below rules -1.Boolean checks should not be inverted,2.Comma operator should not be used,3.Arguments to built-in functions should match documented types,4.Redundant pairs of parentheses should be removed,Thanks,Yogesh MahajanQA - TeamEnterpriseDB Corporation
Phone: +91-9741705709--Thanks & RegardsAkshay JoshiSr. Software ArchitectEnterpriseDB Software India Private LimitedMobile: +91 976-788-8246--Thanks & RegardsAkshay JoshiSr. Software ArchitectEnterpriseDB Software India Private LimitedMobile: +91 976-788-8246
Вложения
Thanks, patch applied.
On Thu, Jun 25, 2020 at 3:53 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi,Please find an updated patch.Thanks,Yogesh MahajanQA - TeamEnterpriseDB Corporation
Phone: +91-9741705709On Thu, Jun 25, 2020 at 12:26 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi YogeshJasmin tests are failing, please fix and resend the patch.On Thu, Jun 25, 2020 at 11:52 AM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:Hi,Please find an updated patch.Thanks,Yogesh MahajanQA - TeamEnterpriseDB Corporation
Phone: +91-9741705709On Wed, Jun 24, 2020 at 12:31 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi YogeshAfter applying your patch a new sonarqube issue has been found "Change this argument to the documented type: Number." in sqleditor_utils.jsPlease fix that and resend the patch.On Mon, Jun 22, 2020 at 4:36 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:Hi Hackers,Please find patch fixing sonarqube issues related to below rules -1.Boolean checks should not be inverted,2.Comma operator should not be used,3.Arguments to built-in functions should match documented types,4.Redundant pairs of parentheses should be removed,Thanks,Yogesh MahajanQA - TeamEnterpriseDB Corporation
Phone: +91-9741705709--Thanks & RegardsAkshay JoshiSr. Software ArchitectEnterpriseDB Software India Private LimitedMobile: +91 976-788-8246--Thanks & RegardsAkshay JoshiSr. Software ArchitectEnterpriseDB Software India Private LimitedMobile: +91 976-788-8246
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246