Обсуждение: [pgAdmin][RM1257] Ensure all object types have a "System XXX?" property

Поиск
Список
Период
Сортировка

[pgAdmin][RM1257] Ensure all object types have a "System XXX?" property

От
Aditya Toshniwal
Дата:
Hi Hackers,

Attached is the patch to add the "System XXX?" property to the object types where it was missing.
I've also attached a allobjects.sql file to create all types of objects under a database for PGv12 which might help to test.
Please review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Вложения

Re: [pgAdmin][RM1257] Ensure all object types have a "System XXX?" property

От
Akshay Joshi
Дата:
Thanks, patch applied.

On Thu, Apr 23, 2020 at 5:04 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to add the "System XXX?" property to the object types where it was missing.
I've also attached a allobjects.sql file to create all types of objects under a database for PGv12 which might help to test.
Please review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

Re: [pgAdmin][RM1257] Ensure all object types have a "System XXX?" property

От
Aditya Toshniwal
Дата:
Hi Hackers,

Attached is the patch to fix:
1. For synonyms, the property is shown as "Public Synonym".
2. For system procedure, the flag should be True but it is displaying as False.
3. For both views and materialized views, the property is "System View".
4. For FTS templates, the property is showing as "System FTS Parser".

Please review.

On Thu, Apr 23, 2020 at 5:33 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.

On Thu, Apr 23, 2020 at 5:04 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to add the "System XXX?" property to the object types where it was missing.
I've also attached a allobjects.sql file to create all types of objects under a database for PGv12 which might help to test.
Please review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Вложения

Re: [pgAdmin][RM1257] Ensure all object types have a "System XXX?" property

От
Akshay Joshi
Дата:
Thanks, patch applied.

On Fri, Apr 24, 2020 at 2:56 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix:
1. For synonyms, the property is shown as "Public Synonym".
2. For system procedure, the flag should be True but it is displaying as False.
3. For both views and materialized views, the property is "System View".
4. For FTS templates, the property is showing as "System FTS Parser".

Please review.

On Thu, Apr 23, 2020 at 5:33 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.

On Thu, Apr 23, 2020 at 5:04 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to add the "System XXX?" property to the object types where it was missing.
I've also attached a allobjects.sql file to create all types of objects under a database for PGv12 which might help to test.
Please review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246