Обсуждение: pgsql: Some refactoring of logical/worker.c

Some refactoring of logical/worker.c

This moves the main operations of apply_handle_{insert|update|delete},
that of inserting, updating, deleting a tuple into/from a given
relation, into corresponding
apply_handle_{insert|update|delete}_internal functions.  This allows
performing those operations on relations that are not directly the
targets of replication, which is something a later patch will use for
targeting partitioned tables.

Author: Amit Langote <amitlangote09@gmail.com>
Reviewed-by: Rafia Sabih <rafia.pghackers@gmail.com>
Reviewed-by: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Discussion:
https://www.postgresql.org/message-id/flat/CA+HiwqH=Y85vRK3mOdjEkqFK+E=ST=eQiHdpj43L=_eJMOOznQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/97ee604d9bcedf0066986521a7ee15e3aa87be34

Modified Files
--------------
src/backend/replication/logical/worker.c | 174 ++++++++++++++++++++-----------
1 file changed, 115 insertions(+), 59 deletions(-)

On 2020-03-24 15:17, Peter Eisentraut wrote:
> Some refactoring of logical/worker.c
> 
> Discussion:
> https://www.postgresql.org/message-id/flat/CA+HiwqH=Y85vRK3mOdjEkqFK+E=ST=eQiHdpj43L=_eJMOOznQ@mail.gmail.com
> 
> Branch
> ------
> master
> 
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/97ee604d9bcedf0066986521a7ee15e3aa87be34
> 
> Modified Files
> --------------
> src/backend/replication/logical/worker.c | 174 
> ++++++++++++++++++++-----------
> 1 file changed, 115 insertions(+), 59 deletions(-)

gcc 9.3.0 mutters under its breath,

worker.c: In function ‘apply_handle_update_internal’:
worker.c:791:22: warning: unused variable ‘remoterel’ 
[-Wunused-variable]
   791 |  LogicalRepRelation *remoterel = &relmapentry->remoterel;
       |

Otherwise the build is fine (documentation build too, including .pdf, 
thanks Tom)


Erik Rijkers

On 2020-03-24 15:39, Erik Rijkers wrote:
> worker.c: In function ‘apply_handle_update_internal’:
> worker.c:791:22: warning: unused variable ‘remoterel’
> [-Wunused-variable]
>     791 |  LogicalRepRelation *remoterel = &relmapentry->remoterel;
>         |

fixed

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services