Обсуждение: pgsql: pg_dump: Add FOREIGN to ALTER statements, if appropriate
pg_dump: Add FOREIGN to ALTER statements, if appropriate Author: Luis Carril Reviewed-by: Tomas Vondra, Daniel Gustafsson, Álvaro Herrera Discussion: https://postgr.es/m/LEJPR01MB0185A19B2E7C98E5E2A031F5E7F20@LEJPR01MB0185.DEUPRD01.PROD.OUTLOOK.DE Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4e62091341b4a55666a32dd7762f185a1faa54f7 Modified Files -------------- src/bin/pg_dump/pg_dump.c | 99 ++++++++++++++++++++++------------------------- 1 file changed, 46 insertions(+), 53 deletions(-)
On 2020-03-20 21:35, Alvaro Herrera wrote: > pg_dump: Add FOREIGN to ALTER statements, if appropriate > > Author: Luis Carril > Reviewed-by: Tomas Vondra, Daniel Gustafsson, Álvaro Herrera > Discussion: > https://postgr.es/m/LEJPR01MB0185A19B2E7C98E5E2A031F5E7F20@LEJPR01MB0185.DEUPRD01.PROD.OUTLOOK.DE > > Branch > ------ > master > > Details > ------- > https://git.postgresql.org/pg/commitdiff/4e62091341b4a55666a32dd7762f185a1faa54f7 > > Modified Files > -------------- > src/bin/pg_dump/pg_dump.c | 99 > ++++++++++++++++++++++------------------------- > 1 file changed, 46 insertions(+), 53 deletions(-) Something not quite right: ./configure --prefix=/home/aardvark/pg_stuff/pg_installations/pgsql.HEAD --bindir=/home/aardvark/pg_stuff/pg_installations/pgsql.HEAD/bin.fast --libdir=/home/aardvark/pg_stuff/pg_installations/pgsql.HEAD/lib.fast --with-pgport=6513 --quiet --enable-depend --with-libxml --with-libxslt --with-zlib --with-openssl --enable-tap-tests --with-extra-version=_HEAD_0320_4e62 pg_dump.c: In function ‘dumpTrigger’: pg_dump.c:17469:51: error: ‘foreign’ undeclared (first use in this function); did you mean ‘fopen’? appendPQExpBuffer(query, "\nALTER %sTABLE %s ", foreign, ^~~~~~~ fopen pg_dump.c:17469:51: note: each undeclared identifier is reported only once for each function it appears in make[3]: *** [../../../src/Makefile.global:920: pg_dump.o] Error 1 make[2]: *** [Makefile:41: all-pg_dump-recurse] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [Makefile:42: all-bin-recurse] Error 2 make: *** [GNUmakefile:11: all-src-recurse] Error 2
On 2020-Mar-20, Erik Rijkers wrote: > pg_dump.c: In function ‘dumpTrigger’: > pg_dump.c:17469:51: error: ‘foreign’ undeclared (first use in this > function); did you mean ‘fopen’? > appendPQExpBuffer(query, "\nALTER %sTABLE %s ", foreign, > ^~~~~~~ > fopen > pg_dump.c:17469:51: note: each undeclared identifier is reported only once > for each function it appears in Yeah, last-minute edit lacking "git add". Pushing now. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services