Обсуждение: pgsql: Record parents of triggers

Record parents of triggers

This let us get rid of a recently introduced ugly hack (commit
1fa846f1c9af).

Author: Álvaro Herrera
Reviewed-by: Amit Langote, Tom Lane
Discussion: https://postgr.es/m/20200217215641.GA29784@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b9b408c487244ef8e6d613d183c56eb2c62990b1

Modified Files
--------------
doc/src/sgml/catalogs.sgml                 | 11 ++++++
src/backend/commands/tablecmds.c           | 59 +++---------------------------
src/backend/commands/trigger.c             |  1 +
src/include/catalog/pg_trigger.h           |  1 +
src/test/regress/expected/sanity_check.out |  3 ++
src/test/regress/expected/triggers.out     |  9 +++++
src/test/regress/sql/triggers.sql          | 10 +++++
7 files changed, 40 insertions(+), 54 deletions(-)

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Modified Files
> --------------
> doc/src/sgml/catalogs.sgml                 | 11 ++++++
> src/backend/commands/tablecmds.c           | 59 +++---------------------------
> src/backend/commands/trigger.c             |  1 +
> src/include/catalog/pg_trigger.h           |  1 +
> src/test/regress/expected/sanity_check.out |  3 ++
> src/test/regress/expected/triggers.out     |  9 +++++
> src/test/regress/sql/triggers.sql          | 10 +++++

Shoulda been a catversion bump in that, no doubt?

            regards, tom lane

On 2020-Feb-27, Tom Lane wrote:

> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > Modified Files
> > --------------
> > doc/src/sgml/catalogs.sgml                 | 11 ++++++
> > src/backend/commands/tablecmds.c           | 59 +++---------------------------
> > src/backend/commands/trigger.c             |  1 +
> > src/include/catalog/pg_trigger.h           |  1 +
> > src/test/regress/expected/sanity_check.out |  3 ++
> > src/test/regress/expected/triggers.out     |  9 +++++
> > src/test/regress/sql/triggers.sql          | 10 +++++
> 
> Shoulda been a catversion bump in that, no doubt?

Augh.  Yeah, will push one now.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

On Thu, Feb 27, 2020 at 05:23:44PM -0300, Alvaro Herrera wrote:
> Augh.  Yeah, will push one now.

devario is complaining with a cache lookup error:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=devario&dt=2020-02-27%2014%3A18%3A34

--- /tmp/buildroot/HEAD/pgsql.build/src/test/regress/expected/triggers.out
2020-02-27 13:00:46.601532974 +0000
+++ /tmp/buildroot/HEAD/pgsql.build/src/bin/pg_upgrade/tmp_check/regress/results/triggers.out
2020-02-27 14:34:13.428974549 +0000
[...]
+ERROR:  cache lookup failed for function 22427
--
Michael