Обсуждение: [pgAdmin][RM5101] debugger not showing all arguments anymore after hitting sql error while debug

Поиск
Список
Период
Сортировка

[pgAdmin][RM5101] debugger not showing all arguments anymore after hitting sql error while debug

От
Aditya Toshniwal
Дата:
Hi Hackers,

Attached is the patch to fix the issue where few of the arguments were skipped when opening arguments dialog other than the first time. The issue occurs when any of the arguments in between is an OUT arg.

I've also added a "Clear All" button to the argument dialog which will clear all the saved arguments values from sqlite db. Document updated.
image.png

The patch also changes the checkboxes used in the arguments dialog to custom checkbox which matches the theme. This was missed in my previous patch related to the same.

Please review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Вложения

Re: [pgAdmin][RM5101] debugger not showing all arguments anymore after hitting sql error while debug

От
Aditya Toshniwal
Дата:
Hi Hackers,

Please ignore the previous patch. Forgot to make the patch with binary option.
Attached is the updated patch.


On Thu, Feb 27, 2020 at 4:13 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix the issue where few of the arguments were skipped when opening arguments dialog other than the first time. The issue occurs when any of the arguments in between is an OUT arg.

I've also added a "Clear All" button to the argument dialog which will clear all the saved arguments values from sqlite db. Document updated.
image.png

The patch also changes the checkboxes used in the arguments dialog to custom checkbox which matches the theme. This was missed in my previous patch related to the same.

Please review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Вложения

Re: [pgAdmin][RM5101] debugger not showing all arguments anymore after hitting sql error while debug

От
Akshay Joshi
Дата:
Thanks, patch applied.

On Fri, Feb 28, 2020 at 12:40 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Please ignore the previous patch. Forgot to make the patch with binary option.
Attached is the updated patch.


On Thu, Feb 27, 2020 at 4:13 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix the issue where few of the arguments were skipped when opening arguments dialog other than the first time. The issue occurs when any of the arguments in between is an OUT arg.

I've also added a "Clear All" button to the argument dialog which will clear all the saved arguments values from sqlite db. Document updated.
image.png

The patch also changes the checkboxes used in the arguments dialog to custom checkbox which matches the theme. This was missed in my previous patch related to the same.

Please review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Вложения