Обсуждение: [PATCH] Addition of JetBrains project directory to .gitignore

This patch simply adds “.idea/“ to the list of global excludes across all subdirectories. This directory is created
whena JetBrains IDE is used to open a project. In my specific case, Clion is creating the project directory. 

The ONLY change in the patch is the “.idea/“ addition to .gitignore.

David Nedrow
dnedrow@me.com

> On 3 Dec 2019, at 15:47, David Nedrow <dnedrow@me.com> wrote:

> This patch simply adds “.idea/“ to the list of global excludes across all subdirectories. This directory is created
whena JetBrains IDE is used to open a project. In my specific case, Clion is creating the project directory. 
>
> The ONLY change in the patch is the “.idea/“ addition to .gitignore.

-1.  This seems like something better suited in a local gitignore for those who
use Jetbrains products. See the documentation for ~/.gitignore_global.

cheers ./daniel

> On 3 Dec 2019, at 15:56, David Nedrow <dnedrow@me.com> wrote:

> Hmmm. I can see that. However, there are already entries for Microsoft Visual C++ at the global level. Wouldn’t this
fallinto the same category? 

Not really, the files in the current .gitignore are artifacts of the build-
system which is provided by the postgres tree (MSVC building, gcov etc); there
are no editor specific files ignored there.

cheers ./daniel

Daniel Gustafsson <daniel@yesql.se> writes:
>> On 3 Dec 2019, at 15:47, David Nedrow <dnedrow@me.com> wrote:
>> This patch simply adds “.idea/“ to the list of global excludes across all subdirectories. This directory is created
whena JetBrains IDE is used to open a project. In my specific case, Clion is creating the project directory. 
>>
>> The ONLY change in the patch is the “.idea/“ addition to .gitignore.

> -1.  This seems like something better suited in a local gitignore for those who
> use Jetbrains products. See the documentation for ~/.gitignore_global.

Yeah, we already have a policy that we won't add entries for, say,
editor backup files.  This seems like the same thing.  It's stuff
generated by a tool you use, and you'd need it for any project
you work on, so a personal ~/.gitexclude seems like the answer.

(Roughly speaking, I think the project policy is/should be that only
junk files created by application of build rules in our Makefiles
should be excluded by our own .gitexclude files.)

As a point of reference, I have

$ cat ~/.gitexclude
*~
*.orig

to suppress emacs backup files and patch backup files respectively.
Somebody who prefers another editor would have no use for *~.

            regards, tom lane

Got it, and that makes sense.

I hereby withdraw this patch. ;)

- David

> On Dec 3, 2019, at 10:08, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Daniel Gustafsson <daniel@yesql.se> writes:
>>>> On 3 Dec 2019, at 15:47, David Nedrow <dnedrow@me.com> wrote:
>>> This patch simply adds “.idea/“ to the list of global excludes across all subdirectories. This directory is created
whena JetBrains IDE is used to open a project. In my specific case, Clion is creating the project directory. 
>>>
>>> The ONLY change in the patch is the “.idea/“ addition to .gitignore.
>
>> -1.  This seems like something better suited in a local gitignore for those who
>> use Jetbrains products. See the documentation for ~/.gitignore_global.
>
> Yeah, we already have a policy that we won't add entries for, say,
> editor backup files.  This seems like the same thing.  It's stuff
> generated by a tool you use, and you'd need it for any project
> you work on, so a personal ~/.gitexclude seems like the answer.
>
> (Roughly speaking, I think the project policy is/should be that only
> junk files created by application of build rules in our Makefiles
> should be excluded by our own .gitexclude files.)
>
> As a point of reference, I have
>
> $ cat ~/.gitexclude
> *~
> *.orig
>
> to suppress emacs backup files and patch backup files respectively.
> Somebody who prefers another editor would have no use for *~.
>
>            regards, tom lane

On Tue, Dec 03, 2019 at 10:07:08AM -0500, Tom Lane wrote:
> As a point of reference, I have
>
> $ cat ~/.gitexclude
> *~
> *.orig
>
> to suppress emacs backup files and patch backup files respectively.
> Somebody who prefers another editor would have no use for *~.

Here are extra entries I use for example:
# Files created by vim for unsaved changes
.*.swp
# Files created by emacs for unsaved changes
.#*
# Temporary files created during compilation
*.o-*
# Tags generated by etags or ctags
TAGS
tags
# Files created by ./configure
conftest.c
conftest.err
confdefs.h
--
Michael