Обсуждение: [pgAdmin4][Patch] - RM #4333 - Add support for function selectivity.
Hi,
Please find the attached patch for the RM #4333 - [PG v12] Add support for function selectivity.
The patch includes:
- Support Function implementation for PG/EPAS 12
- Documentation updates
- API Test cases
Thanks,
Khushboo
Вложения
Hi
In the Trigger and Type dialogues when selecting a function we give a combo box listing all the functions in the database that match the required signature. Can't we do this here as well?
On Fri, Jul 19, 2019 at 9:54 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,Please find the attached patch for the RM #4333 - [PG v12] Add support for function selectivity.The patch includes:- Support Function implementation for PG/EPAS 12- Documentation updates- API Test casesThanks,Khushboo
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, Jul 22, 2019 at 2:07 PM Dave Page <dpage@pgadmin.org> wrote:
HiIn the Trigger and Type dialogues when selecting a function we give a combo box listing all the functions in the database that match the required signature. Can't we do this here as well?
Support function should have specific arguments and return type (i.,e. internal), and the user needs to write the code for that function in the C.
So, what should we consider here?
On Fri, Jul 19, 2019 at 9:54 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hi,Please find the attached patch for the RM #4333 - [PG v12] Add support for function selectivity.The patch includes:- Support Function implementation for PG/EPAS 12- Documentation updates- API Test casesThanks,Khushboo--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, Jul 22, 2019 at 9:59 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
On Mon, Jul 22, 2019 at 2:07 PM Dave Page <dpage@pgadmin.org> wrote:HiIn the Trigger and Type dialogues when selecting a function we give a combo box listing all the functions in the database that match the required signature. Can't we do this here as well?Support function should have specific arguments and return type (i.,e. internal), and the user needs to write the code for that function in the C.So, what should we consider here?
Not sure what you're asking. I suggest we list all functions that match the required signature and are written in C, much as we do elsewhere.
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi Dave,
Please find the attached updated patch.
On Mon, Jul 22, 2019 at 2:07 PM Dave Page <dpage@pgadmin.org> wrote:
HiIn the Trigger and Type dialogues when selecting a function we give a combo box listing all the functions in the database that match the required signature. Can't we do this here as well?
Done.
Thanks,
Khushboo
On Fri, Jul 19, 2019 at 9:54 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hi,Please find the attached patch for the RM #4333 - [PG v12] Add support for function selectivity.The patch includes:- Support Function implementation for PG/EPAS 12- Documentation updates- API Test casesThanks,Khushboo--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
Thanks, applied!
On Tue, Jul 23, 2019 at 6:35 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Dave,Please find the attached updated patch.On Mon, Jul 22, 2019 at 2:07 PM Dave Page <dpage@pgadmin.org> wrote:HiIn the Trigger and Type dialogues when selecting a function we give a combo box listing all the functions in the database that match the required signature. Can't we do this here as well?Done.Thanks,KhushbooOn Fri, Jul 19, 2019 at 9:54 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hi,Please find the attached patch for the RM #4333 - [PG v12] Add support for function selectivity.The patch includes:- Support Function implementation for PG/EPAS 12- Documentation updates- API Test casesThanks,Khushboo--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company