Обсуждение: pgsql: MSVC: Build ~35% faster by calling dumpbin just once perdirecto

Поиск
Список
Период
Сортировка

pgsql: MSVC: Build ~35% faster by calling dumpbin just once perdirecto

От
Noah Misch
Дата:
MSVC: Build ~35% faster by calling dumpbin just once per directory.

Peifeng Qiu

Discussion: https://postgr.es/m/CABmtVJiKXQjast0dQD-8KAtfm8XmyYxo-4Dc7+M+fBr8JRTqkw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/34ff542a71f8e8e768b24d40548dec4be0c707c3

Modified Files
--------------
src/tools/msvc/gendef.pl | 27 ++++++---------------------
1 file changed, 6 insertions(+), 21 deletions(-)


Re: pgsql: MSVC: Build ~35% faster by calling dumpbin just once per directo

От
Tom Lane
Дата:
Noah Misch <noah@leadboat.com> writes:
> MSVC: Build ~35% faster by calling dumpbin just once per directory.

I happened to notice that dory seems to have gotten no benefit at
all from this patch, although the speed change is very apparent
on some other MSVC critters such as whelk and woodlouse.
Puzzling.

            regards, tom lane



Re: pgsql: MSVC: Build ~35% faster by calling dumpbin just once perdirecto

От
Noah Misch
Дата:
On Sun, May 05, 2019 at 06:13:47PM -0400, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > MSVC: Build ~35% faster by calling dumpbin just once per directory.
> 
> I happened to notice that dory seems to have gotten no benefit at
> all from this patch, although the speed change is very apparent
> on some other MSVC critters such as whelk and woodlouse.
> Puzzling.

The author was using parallel builds (MSBFLAGS=/m), as was I.  dory doesn't
seem to be doing so.  I would have guessed more than zero improvement even
without parallelism.  Puzzling, indeed.