Обсуждение: [pgAdmin4][RM#4142] Add the recommended ESLinter checks again.

Поиск
Список
Период
Сортировка

[pgAdmin4][RM#4142] Add the recommended ESLinter checks again.

От
Murtuza Zabuawala
Дата:
Hi,

Issue: We removed recommended ESLinter checking with RM#4019 commit. 

If you see now ESLint is no longer complaining about many issues which are listed here https://eslint.org/docs/rules/ and marked as [✓].
Simple test case is to add debugger; statement in JS code and run linter, we can see that linter is not complaining about it, earlier it was.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Вложения

Re: [pgAdmin4][RM#4142] Add the recommended ESLinter checks again.

От
Akshay Joshi
Дата:
Thanks patch applied.

On Fri, Apr 5, 2019 at 11:49 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

Issue: We removed recommended ESLinter checking with RM#4019 commit. 

If you see now ESLint is no longer complaining about many issues which are listed here https://eslint.org/docs/rules/ and marked as [✓].
Simple test case is to add debugger; statement in JS code and run linter, we can see that linter is not complaining about it, earlier it was.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246