Обсуждение: Incorrect email address in the auth.py module
Poking around in the CF app I noticed that the auth.py module for integrating with the community authentication was out of sync with the copy in the main pgweb repo. Turns out the copy in the CF app is the most up to date as it has fixed the email address in the account merging support email template. The attached patch merges the changes from the CF app copy into the one in the pgweb repo. Unless there are objections I plan to apply this soon. This also fixes an adjacent typo spotted in the process. cheers ./daniel
Вложения
On Wed, Mar 27, 2019 at 2:12 PM Daniel Gustafsson <daniel@yesql.se> wrote:
Poking around in the CF app I noticed that the auth.py module for integrating with
the community authentication was out of sync with the copy in the main pgweb repo.
Turns out the copy in the CF app is the most up to date as it has fixed the email
address in the account merging support email template. The attached patch merges
the changes from the CF app copy into the one in the pgweb repo. Unless there are
objections I plan to apply this soon.
This also fixes an adjacent typo spotted in the process.
That update breaks the commit hook. Have you perhaps forgotten to instlall it? :)
Please make sure that a "pep8" run (with version 2.2.0 or compatible, as that's what's used on the prod servers) passes on the code before pushing! Easiest way is to make sure that the tools/githook/pre-commit is linked into your git hooks directory.
On Wednesday, March 27, 2019 3:51 PM, Magnus Hagander <magnus@hagander.net> wrote:
On Wed, Mar 27, 2019 at 2:12 PM Daniel Gustafsson <daniel@yesql.se> wrote:Poking around in the CF app I noticed that the auth.py module for integrating withthe community authentication was out of sync with the copy in the main pgweb repo.Turns out the copy in the CF app is the most up to date as it has fixed the emailaddress in the account merging support email template. The attached patch mergesthe changes from the CF app copy into the one in the pgweb repo. Unless there areobjections I plan to apply this soon.This also fixes an adjacent typo spotted in the process.That update breaks the commit hook. Have you perhaps forgotten to instlall it? :)
Aha, nice catch. This repo does indeed not run any commit hooks, will fix.
Please make sure that a "pep8" run (with version 2.2.0 or compatible, as that's what's used on the prod servers) passes on the code before pushing! Easiest way is to make sure that the tools/githook/pre-commit is linked into your git hooks directory.
Gotcha, thanks. Any objections to the patch when the above mentioned breakage is resolved?
cheers ./daniel
On Wed, Mar 27, 2019 at 4:50 PM Daniel Gustafsson <daniel@yesql.se> wrote:
On Wednesday, March 27, 2019 3:51 PM, Magnus Hagander <magnus@hagander.net> wrote:On Wed, Mar 27, 2019 at 2:12 PM Daniel Gustafsson <daniel@yesql.se> wrote:Poking around in the CF app I noticed that the auth.py module for integrating withthe community authentication was out of sync with the copy in the main pgweb repo.Turns out the copy in the CF app is the most up to date as it has fixed the emailaddress in the account merging support email template. The attached patch mergesthe changes from the CF app copy into the one in the pgweb repo. Unless there areobjections I plan to apply this soon.This also fixes an adjacent typo spotted in the process.That update breaks the commit hook. Have you perhaps forgotten to instlall it? :)Aha, nice catch. This repo does indeed not run any commit hooks, will fix.Please make sure that a "pep8" run (with version 2.2.0 or compatible, as that's what's used on the prod servers) passes on the code before pushing! Easiest way is to make sure that the tools/githook/pre-commit is linked into your git hooks directory.Gotcha, thanks. Any objections to the patch when the above mentioned breakage is resolved?
No, looks good.
Of course, then we have to sync it out to all the other repos. But for just typos, that can wait :)