Обсуждение: pgsql: Fix typo in documentation of toast storage
Fix typo in documentation of toast storage Author: Nawaz Ahmed Discussion: https://postgr.es/m/154319327168.1315.1846953598601966513@wrigleys.postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/058ef3a1a8469bbaae6b0e6647cd031b9ca71b2d Modified Files -------------- doc/src/sgml/storage.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
On 26/11/2018 07:55, Michael Paquier wrote: > Fix typo in documentation of toast storage > > Author: Nawaz Ahmed > Discussion: https://postgr.es/m/154319327168.1315.1846953598601966513@wrigleys.postgresql.org > > Branch > ------ > master > > Details > ------- > https://git.postgresql.org/pg/commitdiff/058ef3a1a8469bbaae6b0e6647cd031b9ca71b2d > > Modified Files > -------------- > doc/src/sgml/storage.sgml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I don't think this is a correct change? I guess I'll go see the discussion thread, but this looks wrong to me. -- Vik Fearing +33 6 46 75 15 36 http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
On 2018/11/26 16:16, Vik Fearing wrote: > On 26/11/2018 07:55, Michael Paquier wrote: >> Fix typo in documentation of toast storage >> >> Author: Nawaz Ahmed >> Discussion: https://postgr.es/m/154319327168.1315.1846953598601966513@wrigleys.postgresql.org >> >> Branch >> ------ >> master >> >> Details >> ------- >> https://git.postgresql.org/pg/commitdiff/058ef3a1a8469bbaae6b0e6647cd031b9ca71b2d >> >> Modified Files >> -------------- >> doc/src/sgml/storage.sgml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > I don't think this is a correct change? I guess I'll go see the > discussion thread, but this looks wrong to me. Seems that way to me too. A table that has columns with potentially large entries will have an associated <firstterm>TOAST</firstterm> table, which is used for out-of-line storage of -field values that are too large to keep in the table rows proper. +field values that are too large to keep in the table rows properly. I think "in the table rows proper" means something like "in the table rows themselves", although a native speaker can clarify it better. A bit of Internet searching tells that "proper" used like this is a "post-positive adjective" https://english.stackexchange.com/questions/354077/use-of-proper-as-a-postpositive-adjective Thanks, Amit
On Mon, Nov 26, 2018 at 04:36:50PM +0900, Amit Langote wrote: > I think "in the table rows proper" means something like "in the table rows > themselves", although a native speaker can clarify it better. A bit of > Internet searching tells that "proper" used like this is a "post-positive > adjective" > > https://english.stackexchange.com/questions/354077/use-of-proper-as-a-postpositive-adjective Yes, I grabbed that meaning after looking at things around. Anyway, I have reverted the change. This week is going to be long per the odds of the first day.. -- Michael