Обсуждение: pgsql: Remove dead foreign key optimization code
Remove dead foreign key optimization code The ri_KeysEqual() calls in the foreign-key trigger functions to optimize away some updates are useless because since adfeef55cbcc5dc72a772777f88c1be05a70dfee those triggers are not enqueued at all. (It's also not useful to keep these checks as some kind of backstop, since it's also semantically correct to just run the full check even with equal keys.) Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/34479d9a36a280afe1387146871d4c1528cf2cbf Modified Files -------------- src/backend/utils/adt/ri_triggers.c | 51 ------------------------------------- 1 file changed, 51 deletions(-)
On 2018-Nov-10, Peter Eisentraut wrote: > Remove dead foreign key optimization code > > The ri_KeysEqual() calls in the foreign-key trigger functions to > optimize away some updates are useless because since > adfeef55cbcc5dc72a772777f88c1be05a70dfee those triggers are not enqueued > at all. (It's also not useful to keep these checks as some kind of > backstop, since it's also semantically correct to just run the full > check even with equal keys.) > > Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Please don't omit "Discussion:" tags from commit messages. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services