Обсуждение: bloom documentation patch
Hi, Please, consider attached patch, which improves contrib/bloom documentation. Best regards, Oleg -- Postgres Professional: http://www.postgrespro.com The Russian Postgres Company
Вложения
On Mon, Oct 15, 2018 at 10:15 AM Oleg Bartunov <obartunov@postgrespro.ru> wrote: > Please, consider attached patch, which improves contrib/bloom documentation. Hello Oleg, I have no comment on the technical details but here is some proof-reading of the English: + Length of each signature (index entry) in bits, it is rounded up to the nearest + multiple of 16. The default is <literal>80</literal> bits and maximum is s/, it is/. It is/ s/and maximum/and the maximum/ + Bloom AM doesn't supports <literal>unique</literal> indexes. s/supports/support/ + Bloom AM doesn't supports <literal>NULL</literal> values. s/supports/support/ -- Thomas Munro http://www.enterprisedb.com
On Mon, Oct 15, 2018 at 12:48 AM Thomas Munro <thomas.munro@enterprisedb.com> wrote: > > On Mon, Oct 15, 2018 at 10:15 AM Oleg Bartunov <obartunov@postgrespro.ru> wrote: > > Please, consider attached patch, which improves contrib/bloom documentation. > > Hello Oleg, I have no comment on the technical details but here is > some proof-reading of the English: > > + Length of each signature (index entry) in bits, it is rounded > up to the nearest > + multiple of 16. The default is <literal>80</literal> bits and maximum is > > s/, it is/. It is/ > s/and maximum/and the maximum/ > > + Bloom AM doesn't supports <literal>unique</literal> indexes. > > s/supports/support/ > > + Bloom AM doesn't supports <literal>NULL</literal> values. > > s/supports/support/ > Thanks, Thomas, new patch attached. > -- > Thomas Munro > http://www.enterprisedb.com > -- Postgres Professional: http://www.postgrespro.com The Russian Postgres Company
Вложения
On Wed, Oct 17, 2018 at 11:45 PM Oleg Bartunov <obartunov@postgrespro.ru> wrote: > On Mon, Oct 15, 2018 at 12:48 AM Thomas Munro > <thomas.munro@enterprisedb.com> wrote: > > > > On Mon, Oct 15, 2018 at 10:15 AM Oleg Bartunov <obartunov@postgrespro.ru> wrote: > > > Please, consider attached patch, which improves contrib/bloom documentation. > > > > Hello Oleg, I have no comment on the technical details but here is > > some proof-reading of the English: > > > > + Length of each signature (index entry) in bits, it is rounded > > up to the nearest > > + multiple of 16. The default is <literal>80</literal> bits and maximum is > > > > s/, it is/. It is/ > > s/and maximum/and the maximum/ Thank you for these corrections. They are pushed. > > + Bloom AM doesn't supports <literal>unique</literal> indexes. > > > > s/supports/support/ > > > > + Bloom AM doesn't supports <literal>NULL</literal> values. > > > > s/supports/support/ These two were already fixed in the version I've pushed before. ------ Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company