Обсуждение: pgsql: Remove pg_constraint.conincluding

Поиск
Список
Период
Сортировка

pgsql: Remove pg_constraint.conincluding

От
Alvaro Herrera
Дата:
Remove pg_constraint.conincluding

This column was added in commit 8224de4f42cc ("Indexes with INCLUDE
columns and their support in B-tree") to ease writing the ruleutils.c
supporting code for that feature, but it turns out to be unnecessary --
we can do the same thing with just one more syscache lookup.

Even the documentation for the new column being removed in this commit
is awkward.

Discussion: https://postgr.es/m/20180902165018.33otxftp3olgtu4t@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c076f3d74af6e4836206142446bdcc2f93e149d6

Modified Files
--------------
doc/src/sgml/catalogs.sgml                    |  8 ----
src/backend/catalog/pg_constraint.c           | 21 ----------
src/backend/utils/adt/ruleutils.c             | 57 +++++++++++++++++++++------
src/include/catalog/catversion.h              |  2 +-
src/include/catalog/pg_constraint.h           |  6 ---
src/test/regress/expected/index_including.out | 40 +++++++++----------
src/test/regress/sql/index_including.sql      | 10 ++---
7 files changed, 71 insertions(+), 73 deletions(-)