Обсуждение: BUG #15356: Inconsistent documentation about CREATE TYPE

The following bug has been logged on the website:

Bug reference:      15356
Logged by:          Lukas Eder
Email address:      lukas.eder@gmail.com
PostgreSQL version: 10.5
Operating system:   Windows
Description:

Hello,

The CREATE TYPE documentation [1] specifies that enum types without any enum
labels are possible:

    CREATE TYPE name AS ENUM ( [ 'label' [, ... ] ] )

I can confirm this. The following statement works well:

    CREATE TYPE e AS ENUM ();

However, further down in the same documentation page, we can see:

    "Enum types take a list of one or more quoted labels"

It should read "zero or more quoted labels". I suspect this should be
adapted on all documentation pages from PostgreSQL 9.0 onwards. In 8.4, the
documentation was consistent [2]

[1]: https://www.postgresql.org/docs/current/static/sql-createtype.html
[2]: https://www.postgresql.org/docs/8.4/static/sql-createtype.html

On 28/08/2018 14:56, PG Bug reporting form wrote:
> The CREATE TYPE documentation [1] specifies that enum types without any enum
> labels are possible:
> 
>     CREATE TYPE name AS ENUM ( [ 'label' [, ... ] ] )
> 
> I can confirm this. The following statement works well:
> 
>     CREATE TYPE e AS ENUM ();
> 
> However, further down in the same documentation page, we can see:
> 
>     "Enum types take a list of one or more quoted labels"
> 
> It should read "zero or more quoted labels". I suspect this should be
> adapted on all documentation pages from PostgreSQL 9.0 onwards. In 8.4, the
> documentation was consistent [2]

Right.  How about the attached patch?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

On 13/11/2018 11:01, Lukas Eder wrote:
>     > The CREATE TYPE documentation [1] specifies that enum types
>     without any enum
>     > labels are possible:
>     >
>     >     CREATE TYPE name AS ENUM ( [ 'label' [, ... ] ] )
>     >
>     > I can confirm this. The following statement works well:
>     >
>     >     CREATE TYPE e AS ENUM ();
>     >
>     > However, further down in the same documentation page, we can see:
>     >
>     >     "Enum types take a list of one or more quoted labels"
>     >
>     > It should read "zero or more quoted labels". I suspect this should be
>     > adapted on all documentation pages from PostgreSQL 9.0 onwards. In
>     8.4, the
>     > documentation was consistent [2]
> 
>     Right.  How about the attached patch?
> 
> Makes sense, thanks 

committed

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services