Обсуждение: Refactor documentation for wait events (Was: pgsql: Add wait eventfor fsync of WAL segments)

On Fri, Jul 13, 2018 at 04:57:59PM -0500, Robert Haas wrote:
> On Mon, Jul 9, 2018 at 4:41 PM, Michael Paquier <michael@paquier.xyz> wrote:
>> Another idea that I have here, is to rework the page for monitoring
>> stats so as we create one sub-section for each system view, and also one
>> for the table of wait events.  For the wait events, we could then
>> completely remove the first category column which has morerows and
>> divide the section into on table per event category.
>
> +1 from me.  I think I proposed that before.

Attached is a proof of concept of that.  I have divided the "Viewing
Statistics" section into a subset for each catalog, and each wait event
type gains its sub-section as well.  There is a bit more to do with the
indentation and some xreflabels, but I think that this is enough to
begin a discussion.

Thoughts?
--
Michael

On Sun, Jul 15, 2018 at 10:10 PM, Michael Paquier <michael@paquier.xyz> wrote:
> On Fri, Jul 13, 2018 at 04:57:59PM -0500, Robert Haas wrote:
>> On Mon, Jul 9, 2018 at 4:41 PM, Michael Paquier <michael@paquier.xyz> wrote:
>>> Another idea that I have here, is to rework the page for monitoring
>>> stats so as we create one sub-section for each system view, and also one
>>> for the table of wait events.  For the wait events, we could then
>>> completely remove the first category column which has morerows and
>>> divide the section into on table per event category.
>>
>> +1 from me.  I think I proposed that before.
>
> Attached is a proof of concept of that.  I have divided the "Viewing
> Statistics" section into a subset for each catalog, and each wait event
> type gains its sub-section as well.  There is a bit more to do with the
> indentation and some xreflabels, but I think that this is enough to
> begin a discussion.
>
> Thoughts?

This doesn't seem to get rid of the morerows stuff.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Jul 16, 2018 at 11:22:07AM -0400, Robert Haas wrote:
> This doesn't seem to get rid of the morerows stuff.

The troubling ones are in monitoring.sgml:
<entry morerows="64"><literal>LWLock</literal></entry>
<entry morerows="9"><literal>Lock</literal></entry>
<entry morerows="13"><literal>Activity</literal></entry>
<entry morerows="7"><literal>Client</literal></entry>
<entry morerows="33"><literal>IPC</literal></entry>
<entry morerows="2"><literal>Timeout</literal></entry>
<entry morerows="66"><literal>IO</literal></entry>

And the patch previously sent removes them, but perhaps I am missing
your point?
--
Michael

On Tue, Jul 17, 2018 at 12:19 AM, Michael Paquier <michael@paquier.xyz> wrote:
> And the patch previously sent removes them, but perhaps I am missing
> your point?

I was just confused.  Sorry for the noise.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company