Обсуждение: Patch to support service parameter & german translation

Hi,

attached three patches:

0001-Add-support-for-service-connection-parameters-TODO-U.patch

    Adds support for the service parameter in connections
    (see https://www.postgresql.org/docs/current/static/libpq-pgservice.html)

0002-add-german-translation.patch

    Adds German UI.  Also includes some dialog layout fixes for the U.S.
    version.

0003-Add-service-control-to-japanese-dialog.patch

    Add the service field to the japanese ui (please check
    the label - translated using google).


Please review and if ok apply.  Thanks.


Jürgen

--
Jürgen E. Fischer           norBIT GmbH             Tel. +49-4931-918175-31
Dipl.-Inf. (FH)             Rheinstraße 13          Fax. +49-4931-918175-50
Software Engineer           D-26506 Norden             http://www.norbit.de
QGIS release manager (PSC)  Germany                    IRC: jef on FreeNode

Hi Jürgen,

Thanks for the patches.

However, is it bad to use pqopt option?
The pqopt option is available since 9.6.1.

regards,
Hiroshi Inoue

On 2018/06/28 0:35, Jürgen E. Fischer wrote:
> Hi,
>
> attached three patches:
>
> 0001-Add-support-for-service-connection-parameters-TODO-U.patch
>
>     Adds support for the service parameter in connections
>     (see https://www.postgresql.org/docs/current/static/libpq-pgservice.html)
>
> 0002-add-german-translation.patch
>
>     Adds German UI.  Also includes some dialog layout fixes for the U.S.
>     version.
>
> 0003-Add-service-control-to-japanese-dialog.patch
>
>     Add the service field to the japanese ui (please check
>     the label - translated using google).
>
>
> Please review and if ok apply.  Thanks.
>
>
> Jürgen

Hi Hiorshi,

On Thu, 28. Jun 2018 at 11:59:26 +0900, Inoue, Hiroshi wrote:
> Thanks for the patches.

> However, is it bad to use pqopt option?
> The pqopt option is available since 9.6.1.

Well, I'd prefer to have it more visible (but I'm biased as I spent most of the
time fiddling on the rc file ;))


Jürgen

--
Jürgen E. Fischer           norBIT GmbH             Tel. +49-4931-918175-31
Dipl.-Inf. (FH)             Rheinstraße 13          Fax. +49-4931-918175-50
Software Engineer           D-26506 Norden             http://www.norbit.de
QGIS release manager (PSC)  Germany                    IRC: jef on FreeNode

Hi Jürgen,

On 2018/06/28 15:50, Jürgen E. Fischer wrote:
> Hi Hiorshi,
>
> On Thu, 28. Jun 2018 at 11:59:26 +0900, Inoue, Hiroshi wrote:
>> Thanks for the patches.
>   
>> However, is it bad to use pqopt option?
>> The pqopt option is available since 9.6.1.
> Well, I'd prefer to have it more visible (but I'm biased as I spent most of the
> time fiddling on the rc file ;))

I introduced pqopt option so as not to add individual libpq option any more.

BTW I want to apply your patch to add German UI.
Could you continue to maintain the UI?

regards,
Hiroshi Inoue

>
>
> Jürgen

Hi Hiroshi,

On Fri, 29. Jun 2018 at 16:43:49 +0900, Inoue, Hiroshi wrote:
> On 2018/06/28 15:50, Jürgen E. Fischer wrote:
> > On Thu, 28. Jun 2018 at 11:59:26 +0900, Inoue, Hiroshi wrote:
> > > Thanks for the patches.
> > > However, is it bad to use pqopt option?
> > > The pqopt option is available since 9.6.1.
> > Well, I'd prefer to have it more visible (but I'm biased as I spent most of the
> > time fiddling on the rc file ;))

> I introduced pqopt option so as not to add individual libpq option any more.

To me the service is on the same level as the other options (same as in pgadmin
and QGIS for instance) - so having it on the front page would still be nice.

> BTW I want to apply your patch to add German UI.
> Could you continue to maintain the UI?

Sure.


Jürgen

--
Jürgen E. Fischer         norBIT GmbH               Tel. +49-4931-918175-31
Dipl.-Inf. (FH)           Rheinstraße 13            Fax. +49-4931-918175-50
Software Engineer         D-26506 Norden               http://www.norbit.de

Hi,

On Fri, 29. Jun 2018 at 10:25:45 +0200, Jürgen E. Fischer wrote:
> > I introduced pqopt option so as not to add individual libpq option any more.

> To me the service is on the same level as the other options (same as in pgadmin
> and QGIS for instance) - so having it on the front page would still be nice.

> > BTW I want to apply your patch to add German UI.
> > Could you continue to maintain the UI?

> Sure.

FYI I added a fix for the german translation to
https://github.com/jef-n/psqlodbc.


Jürgen

--
Jürgen E. Fischer         norBIT GmbH               Tel. +49-4931-918175-31
Dipl.-Inf. (FH)           Rheinstraße 13            Fax. +49-4931-918175-50
Software Engineer         D-26506 Norden               http://www.norbit.de