Обсуждение: Dead link in ltree documentation
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/10/static/ltree.html Description: Hi, https://www.postgresql.org/docs/current/static/ltree.html links to www.dmoz.org which now returns a 403, since being closed down in 2017. Maybe it could link to the mirror https://dmoztools.net/ or the wikipedia page instead.
Postgres Professional: http://www.postgrespro.com The Russian Postgres Company On Wed, Apr 4, 2018 at 12:59 PM, PG Doc comments form <noreply@postgresql.org> wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/10/static/ltree.html > Description: > > Hi, > > https://www.postgresql.org/docs/current/static/ltree.html links to > www.dmoz.org which now returns a 403, since being closed down in 2017. > > Maybe it could link to the mirror https://dmoztools.net/ or the wikipedia > page instead. Attached is a small patch.
Вложения
On Wed, Apr 4, 2018 at 03:46:06PM +0300, Oleg Bartunov wrote: > Postgres Professional: http://www.postgrespro.com > The Russian Postgres Company > > > On Wed, Apr 4, 2018 at 12:59 PM, PG Doc comments form > <noreply@postgresql.org> wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/10/static/ltree.html > > Description: > > > > Hi, > > > > https://www.postgresql.org/docs/current/static/ltree.html links to > > www.dmoz.org which now returns a 403, since being closed down in 2017. > > > > Maybe it could link to the mirror https://dmoztools.net/ or the wikipedia > > page instead. > > Attached is a small patch. > --- ltree.sgml.orig 2017-12-20 16:40:26.000000000 +0300 > +++ ltree.sgml 2018-04-04 15:43:01.000000000 +0300 > @@ -34,7 +34,7 @@ > length of a label path must be less than 65kB, but keeping it under 2kB is > preferable. In practice this is not a major limitation; for example, > the longest label path in the DMOZ catalog (<ulink > - url="http://www.dmoz.org"></ulink>) is about 240 bytes. > + url="http://www.dmoztools.net"></ulink>) is about 271 bytes. > </para> > > <para> Patch applied back through 9.3. Thanks. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
On Wed, Apr 4, 2018 at 03:46:06PM +0300, Oleg Bartunov wrote:
> Postgres Professional: http://www.postgrespro.com
> The Russian Postgres Company
>
>
> On Wed, Apr 4, 2018 at 12:59 PM, PG Doc comments form
> <noreply@postgresql.org> wrote:
> > The following documentation comment has been logged on the website:
> >
> > Page: https://www.postgresql.org/docs/10/static/ltree.html
> > Description:
> >
> > Hi,
> >
> > https://www.postgresql.org/docs/current/static/ltree.html links to
> > www.dmoz.org which now returns a 403, since being closed down in 2017.
> >
> > Maybe it could link to the mirror https://dmoztools.net/ or the wikipedia
> > page instead.
>
> Attached is a small patch.
> --- ltree.sgml.orig 2017-12-20 16:40:26.000000000 +0300
> +++ ltree.sgml 2018-04-04 15:43:01.000000000 +0300
> @@ -34,7 +34,7 @@
> length of a label path must be less than 65kB, but keeping it under 2kB is
> preferable. In practice this is not a major limitation; for example,
> the longest label path in the DMOZ catalog (<ulink
> - url="http://www.dmoz.org"></ulink>) is about 240 bytes.
> + url="http://www.dmoztools.net"></ulink>) is about 271 bytes.
> </para>
>
> <para>
Patch applied back through 9.3. Thanks.
I'm not seeing the value in providing a link, especially one that we don't control, here. Futhermore, we could probably drop the whole "In practice..." sentence. But if not at least put a period after "limitation" and drop the example and link.
David J.
On Wed, Apr 4, 2018 at 1:02 PM, David G. Johnston <david.g.johnston@gmail.com> wrote:
FYI - Bruce's "I've committed this" email is the only one in the thread that made it into my inbox...pgsql-docs emails seem to be getting swallowed in the void sometimes.
David J.
David G. Johnston wrote: > I'm not seeing the value in providing a link, especially one that we don't > control, here. Futhermore, we could probably drop the whole "In > practice..." sentence. But if not at least put a period after "limitation" > and drop the example and link. +1 remove the sentence. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Wed, Apr 4, 2018 at 8:17 PM, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: > David G. Johnston wrote: > >> I'm not seeing the value in providing a link, especially one that we don't >> control, here. Futhermore, we could probably drop the whole "In >> practice..." sentence. But if not at least put a period after "limitation" >> and drop the example and link. > > +1 remove the sentence. Attached is a new patch, which removed the whole sentence with example link. > > -- > Álvaro Herrera https://www.2ndQuadrant.com/ > PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Postgres Professional: http://www.postgrespro.com The Russian Postgres Company
Вложения
On Thu, Apr 5, 2018 at 11:54:19AM +0000, Oleg Bartunov wrote: > On Wed, Apr 4, 2018 at 8:17 PM, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: > > David G. Johnston wrote: > > > >> I'm not seeing the value in providing a link, especially one that we don't > >> control, here. Futhermore, we could probably drop the whole "In > >> practice..." sentence. But if not at least put a period after "limitation" > >> and drop the example and link. > > > > +1 remove the sentence. > > Attached is a new patch, which removed the whole sentence with example link. Patch applied and backpatched through 9.3. Thanks. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +