Обсуждение: RM3079 fix for wrong sql datetime/time related datatypes

Hello Harshal,

I tried the example you showed and it works. Also passed the patch through our CI Pipeline and everything is good.

Thanks

Joao

On Wed, Feb 28, 2018 at 6:25 AM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

On Tue, Feb 27, 2018 at 8:54 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Tue, Feb 27, 2018 at 2:36 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

Please find patch to fix wrong sql issue for time related type.

Steps to reproduce:

Alter any time/datetime array related data type, it generates sql with addition array bracket

This seems to be missing the test case that you noted should be included in the original bug report! 

Please find updated patch with test cases. 

Thanks,

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Great, thanks! 

On Feb 28, 2018 8:15 PM, "Joao De Almeida Pereira" <jdealmeidapereira@pivotal.io> wrote:

Hello Harshal,

I tried the example you showed and it works. Also passed the patch through our CI Pipeline and everything is good.

Thanks

Joao

On Wed, Feb 28, 2018 at 6:25 AM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

On Tue, Feb 27, 2018 at 8:54 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Tue, Feb 27, 2018 at 2:36 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

Please find patch to fix wrong sql issue for time related type.

Steps to reproduce:

Alter any time/datetime array related data type, it generates sql with addition array bracket

This seems to be missing the test case that you noted should be included in the original bug report! 

Please find updated patch with test cases. 

Thanks,

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company