Обсуждение: [pgAdmin4][RM#3121] Fix PEP-8 issues

Поиск
Список
Период
Сортировка

[pgAdmin4][RM#3121] Fix PEP-8 issues

От
Murtuza Zabuawala
Дата:
Hi,

PFA patch to fix the PEP-8 issues,

To verify changes goto '../web' directory and run,
pycodestyle --config=.pycodestyle ./regression/
pycodestyle --config=.pycodestyle ./pgadmin/setup/
pycodestyle --config=.pycodestyle ./pgadmin/settings/
pycodestyle --config=.pycodestyle ./pgadmin/redirects/
pycodestyle --config=.pycodestyle ./pgadmin/preferences/
pycodestyle --config=.pycodestyle ./pgadmin/model/
pycodestyle --config=.pycodestyle ./pgadmin/help/


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Вложения

Re: [pgAdmin4][RM#3121] Fix PEP-8 issues

От
Joao De Almeida Pereira
Дата:
Hello Murtuza,
I just run this patch as you suggested(no errors reported) and also run it through our CI pipeline and it look good

Thanks
Joao

On Wed, Feb 14, 2018 at 7:23 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the PEP-8 issues,

To verify changes goto '../web' directory and run,
pycodestyle --config=.pycodestyle ./regression/
pycodestyle --config=.pycodestyle ./pgadmin/setup/
pycodestyle --config=.pycodestyle ./pgadmin/settings/
pycodestyle --config=.pycodestyle ./pgadmin/redirects/
pycodestyle --config=.pycodestyle ./pgadmin/preferences/
pycodestyle --config=.pycodestyle ./pgadmin/model/
pycodestyle --config=.pycodestyle ./pgadmin/help/


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][RM#3121] Fix PEP-8 issues

От
Murtuza Zabuawala
Дата:
Thank you for reviewing Joao.


On Thu, Feb 15, 2018 at 8:37 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Murtuza,
I just run this patch as you suggested(no errors reported) and also run it through our CI pipeline and it look good

Thanks
Joao

On Wed, Feb 14, 2018 at 7:23 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the PEP-8 issues,

To verify changes goto '../web' directory and run,
pycodestyle --config=.pycodestyle ./regression/
pycodestyle --config=.pycodestyle ./pgadmin/setup/
pycodestyle --config=.pycodestyle ./pgadmin/settings/
pycodestyle --config=.pycodestyle ./pgadmin/redirects/
pycodestyle --config=.pycodestyle ./pgadmin/preferences/
pycodestyle --config=.pycodestyle ./pgadmin/model/
pycodestyle --config=.pycodestyle ./pgadmin/help/


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: [pgAdmin4][RM#3121] Fix PEP-8 issues

От
Dave Page
Дата:
Thanks, patch applied.

On Thu, Feb 15, 2018 at 4:15 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Thank you for reviewing Joao.


On Thu, Feb 15, 2018 at 8:37 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Murtuza,
I just run this patch as you suggested(no errors reported) and also run it through our CI pipeline and it look good

Thanks
Joao

On Wed, Feb 14, 2018 at 7:23 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the PEP-8 issues,

To verify changes goto '../web' directory and run,
pycodestyle --config=.pycodestyle ./regression/
pycodestyle --config=.pycodestyle ./pgadmin/setup/
pycodestyle --config=.pycodestyle ./pgadmin/settings/
pycodestyle --config=.pycodestyle ./pgadmin/redirects/
pycodestyle --config=.pycodestyle ./pgadmin/preferences/
pycodestyle --config=.pycodestyle ./pgadmin/model/
pycodestyle --config=.pycodestyle ./pgadmin/help/


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company