Обсуждение: pgAdmin4: Patch for RM#3060

Поиск
Список
Период
Сортировка

pgAdmin4: Patch for RM#3060

От
navnath gadakh
Дата:
Hi Dave,
 
           Please find the patch for function name quoting in SQL tab for functions.(RM#3060)

Files affected:
pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/function/pg/sql/default/get_definition.sql

I have added code for quoting string wherever needed.

Thanks Harshal for help!

--
Regards,
navnath


Вложения

Re: pgAdmin4: Patch for RM#3060

От
Dave Page
Дата:
Hi

On Tue, Feb 6, 2018 at 11:49 AM, navnath gadakh <navnath.gadakh@enterprisedb.com> wrote:
Hi Dave,
 
           Please find the patch for function name quoting in SQL tab for functions.(RM#3060)

Files affected:
pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/function/pg/sql/default/get_definition.sql

I have added code for quoting string wherever needed.

Thanks Harshal for help!

Unfortunately this doesn't apply. Can you rebase it please?

Thanks! 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: pgAdmin4: Patch for RM#3060

От
Dave Page
Дата:


On Fri, Feb 9, 2018 at 10:06 AM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Tue, Feb 6, 2018 at 11:49 AM, navnath gadakh <navnath.gadakh@enterprisedb.com> wrote:
Hi Dave,
 
           Please find the patch for function name quoting in SQL tab for functions.(RM#3060)

Files affected:
pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/function/pg/sql/default/get_definition.sql

I have added code for quoting string wherever needed.

Thanks Harshal for help!

Unfortunately this doesn't apply. Can you rebase it please?

Hold that - my tree wasn't clean...
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: pgAdmin4: Patch for RM#3060

От
Dave Page
Дата:
Thanks - patch applied!

On Tue, Feb 6, 2018 at 11:49 AM, navnath gadakh <navnath.gadakh@enterprisedb.com> wrote:
Hi Dave,
 
           Please find the patch for function name quoting in SQL tab for functions.(RM#3060)

Files affected:
pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/function/pg/sql/default/get_definition.sql

I have added code for quoting string wherever needed.

Thanks Harshal for help!

--
Regards,
navnath





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company