Обсуждение: [BUGS] BUG #14775: Incorrect documentation for the Commit logicalreplication message format
[BUGS] BUG #14775: Incorrect documentation for the Commit logicalreplication message format
От
kyle@kyleconroy.com
Дата:
The following bug has been logged on the website: Bug reference: 14775 Logged by: Kyle Conroy Email address: kyle@kyleconroy.com PostgreSQL version: 10beta2 Operating system: macOS Description: The Commit message format is incorrectly documented. The `flags` field[0] is missing. I ran into this while creating a parser for the messages in Golang. [0] https://github.com/postgres/postgres/blob/master/src/backend/replication/logical/proto.c#L80 -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
Re: [BUGS] BUG #14775: Incorrect documentation for the Commit logicalreplication message format
От
Masahiko Sawada
Дата:
On Wed, Aug 9, 2017 at 2:08 PM, <kyle@kyleconroy.com> wrote: > The following bug has been logged on the website: > > Bug reference: 14775 > Logged by: Kyle Conroy > Email address: kyle@kyleconroy.com > PostgreSQL version: 10beta2 > Operating system: macOS > Description: > > The Commit message format is incorrectly documented. The `flags` field[0] is > missing. I ran into this while creating a parser for the messages in > Golang. > > [0] > https://github.com/postgres/postgres/blob/master/src/backend/replication/logical/proto.c#L80 > Thank you for reporting. Yeah, it's not used actually for now but should be documented. Attached patch. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
Вложения
Re: [BUGS] BUG #14775: Incorrect documentation for the Commit logicalreplication message format
От
Peter Eisentraut
Дата:
On 8/10/17 04:21, Masahiko Sawada wrote: >> The Commit message format is incorrectly documented. The `flags` field[0] is >> missing. I ran into this while creating a parser for the messages in >> Golang. >> >> [0] >> https://github.com/postgres/postgres/blob/master/src/backend/replication/logical/proto.c#L80 >> > > Thank you for reporting. Yeah, it's not used actually for now but > should be documented. Attached patch. Committed, thanks! -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
Re: [BUGS] BUG #14775: Incorrect documentation for the Commit logicalreplication message format
От
Masahiko Sawada
Дата:
On Tue, Aug 15, 2017 at 2:45 AM, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote: > On 8/10/17 04:21, Masahiko Sawada wrote: >>> The Commit message format is incorrectly documented. The `flags` field[0] is >>> missing. I ran into this while creating a parser for the messages in >>> Golang. >>> >>> [0] >>> https://github.com/postgres/postgres/blob/master/src/backend/replication/logical/proto.c#L80 >>> >> >> Thank you for reporting. Yeah, it's not used actually for now but >> should be documented. Attached patch. > > Committed, thanks! > Thank you for committing! Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs