Обсуждение: [COMMITTERS] pgsql: Add support for ICU 4.2
Add support for ICU 4.2 Supporting ICU 4.2 seems useful because it ships with CentOS 6. Versions before ICU 4.6 don't support pkg-config, so document an installation method without using pkg-config. In ICU 4.2, ucol_getKeywordsForLocale() sometimes returns values that will not be accepted by uloc_toLanguageTag(). Skip loading keyword variants in that version. Reported-by: Victor Wagner <vitus@wagner.pp.ru> Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/eccead9ed43dc6e653c76dce1d2f455d251bb00c Modified Files -------------- doc/src/sgml/installation.sgml | 22 +++++++++++++++++++--- src/backend/commands/collationcmds.c | 11 +++++++++++ 2 files changed, 30 insertions(+), 3 deletions(-)
On Sat, Aug 5, 2017 at 6:36 AM, Peter Eisentraut <peter_e@gmx.net> wrote: > In ICU 4.2, ucol_getKeywordsForLocale() sometimes returns values that > will not be accepted by uloc_toLanguageTag(). Skip loading keyword > variants in that version. This should be spelled ucol_getKeywordValuesForLocale() in both the commit message and the code comment. There is no ucol_getKeywordsForLocale() function. -- Peter Geoghegan
On 8/6/17 20:40, Peter Geoghegan wrote: > On Sat, Aug 5, 2017 at 6:36 AM, Peter Eisentraut <peter_e@gmx.net> wrote: >> In ICU 4.2, ucol_getKeywordsForLocale() sometimes returns values that >> will not be accepted by uloc_toLanguageTag(). Skip loading keyword >> variants in that version. > > This should be spelled ucol_getKeywordValuesForLocale() in both the > commit message and the code comment. There is no > ucol_getKeywordsForLocale() function. Fixed, thanks. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services