Обсуждение: [HACKERS] documentation typo in ALTER TABLE example

Hi,

Attached is a simple patch to fix a documentation typo in
the ALTER TABLE example.

Regards,

-- 
Yugo Nagata <nagata@sraoss.co.jp>

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

> Hi,
> 
> Attached is a simple patch to fix a documentation typo in
> the ALTER TABLE example.

Or the original author's intention might have been something like
this:

--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -1399,7 +1399,7 @@ ALTER TABLE cities   Detach a partition from partitioned table:<programlisting>ALTER TABLE
cities
-    DETACH PARTITION measurement_y2015m12;
+    DETACH PARTITION cities_ab;

Amit Langote, which one was your intention?
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

On 2017/06/12 11:01, Tatsuo Ishii wrote:
>> Hi,
>>
>> Attached is a simple patch to fix a documentation typo in
>> the ALTER TABLE example.
> 
> Or the original author's intention might have been something like
> this:
> 
> --- a/doc/src/sgml/ref/alter_table.sgml
> +++ b/doc/src/sgml/ref/alter_table.sgml
> @@ -1399,7 +1399,7 @@ ALTER TABLE cities
>     Detach a partition from partitioned table:
>  <programlisting>
>  ALTER TABLE cities
> -    DETACH PARTITION measurement_y2015m12;
> +    DETACH PARTITION cities_ab;
> 
> Amit Langote, which one was your intention?

I wanted to show DETACH PARTITION command's usage with a range partitioned
table (detaching the "oldest" partition).

So, we should apply Nagata-san's patch.

Thanks,
Amit

>> Amit Langote, which one was your intention?
> 
> I wanted to show DETACH PARTITION command's usage with a range partitioned
> table (detaching the "oldest" partition).
> 
> So, we should apply Nagata-san's patch.

Thank you for the confirmation. I have pushed the patch.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp