Обсуждение: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

Thanks, applied. I removed the doc comments from the CSS for now as we
don't have minimisation for that yet (and one of them seemed to be
garbage).

On Mon, Jun 5, 2017 at 4:52 PM, Shruti B Iyer <siyer@pivotal.io> wrote:
> Hi Hackers
>
> Attached are two patches for styling improvements.
> 1-add-style-guide.patch contains the initial css from the style guide. As we
> make further style changes, this file will be updated.
> 2-change-grays.patch changes the gray color elements in the app to the ones
> in the new style guide.
>
> Thanks,
> Shruti and Matt
>
>

> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi
>
> With the latest pull, I found:
> The header color of Properties panel disappears and background color of
> footer area in Edit Properties panel is changed.

Oh, I missed that :-(. Can you come up with a quick fix using the new classes?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Sure I will send.

On Wed, Jun 7, 2017 at 6:54 PM, Dave Page <dpage@pgadmin.org> wrote:

On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi
>
> With the latest pull, I found:
> The header color of Properties panel disappears and background color of
> footer area in Edit Properties panel is changed.

Oh, I missed that :-(. Can you come up with a quick fix using the new classes?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Thank you. 

-- Rob

On Wed, Jun 7, 2017 at 9:28 AM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:

Sure I will send.

On Wed, Jun 7, 2017 at 6:54 PM, Dave Page <dpage@pgadmin.org> wrote:

On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi
>
> With the latest pull, I found:
> The header color of Properties panel disappears and background color of
> footer area in Edit Properties panel is changed.

Oh, I missed that :-(. Can you come up with a quick fix using the new classes?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Thanks, applied.

On Wed, Jun 7, 2017 at 3:48 PM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi
>
> I have used classes 'bg-gray-2 border-gray-3' for styling header and footer
> of properties panel which are also used in other places.
>
> Please find attached patch.
>
>
> On Wed, Jun 7, 2017 at 6:59 PM, Robert Eckhardt <reckhardt@pivotal.io>
> wrote:
>>
>> Thank you.
>>
>> -- Rob
>>
>> On Wed, Jun 7, 2017 at 9:28 AM, Surinder Kumar
>> <surinder.kumar@enterprisedb.com> wrote:
>>>
>>> Sure I will send.
>>>
>>> On Wed, Jun 7, 2017 at 6:54 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>>
>>>> On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar
>>>> <surinder.kumar@enterprisedb.com> wrote:
>>>> > Hi
>>>> >
>>>> > With the latest pull, I found:
>>>> > The header color of Properties panel disappears and background color
>>>> > of
>>>> > footer area in Edit Properties panel is changed.
>>>>
>>>> Oh, I missed that :-(. Can you come up with a quick fix using the new
>>>> classes?
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>
>>>
>>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Hi Murtuza,

This was before we had checkboxes removed and added column and row highlighting. Try looking at this now with the query results grid updates and let me know what you think.

On Thu, Jun 8, 2017 at 1:19 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hello,

I think we could have use some different grey colour shade for SlickGrid headers from wcDocker panel, It does not look bad but as a end user I'm not able to differentiate between them now, please refer screenshot attached.

Is this expected with new design style?

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jun 7, 2017 at 9:01 PM, Dave Page <dpage@pgadmin.org> wrote:

Thanks, applied.

On Wed, Jun 7, 2017 at 3:48 PM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi
>
> I have used classes 'bg-gray-2 border-gray-3' for styling header and footer
> of properties panel which are also used in other places.
>
> Please find attached patch.
>
>
> On Wed, Jun 7, 2017 at 6:59 PM, Robert Eckhardt <reckhardt@pivotal.io>
> wrote:
>>
>> Thank you.
>>
>> -- Rob
>>
>> On Wed, Jun 7, 2017 at 9:28 AM, Surinder Kumar
>> <surinder.kumar@enterprisedb.com> wrote:
>>>
>>> Sure I will send.
>>>
>>> On Wed, Jun 7, 2017 at 6:54 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>>
>>>> On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar
>>>> <surinder.kumar@enterprisedb.com> wrote:
>>>> > Hi
>>>> >
>>>> > With the latest pull, I found:
>>>> > The header color of Properties panel disappears and background color
>>>> > of
>>>> > footer area in Edit Properties panel is changed.
>>>>
>>>> Oh, I missed that :-(. Can you come up with a quick fix using the new
>>>> classes?
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>
>>>
>>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers