Обсуждение: [HACKERS] monitoring.sgml missing tag

monitoring.sgml has one </row> tag missing
-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On 2017-04-07 22:47:55 +0200, Erik Rijkers wrote:
> monitoring.sgml has one </row> tag missing

Is that actually an issue? SGML allows skipping certain close tags, and
IIRC row is one them.  We'll probably move to xml at some point not too
far away, but I don't think it makes much sense to fix these one-by-one.

Greetings,

Andres Freund

On 2017-04-07 22:50, Andres Freund wrote:
> On 2017-04-07 22:47:55 +0200, Erik Rijkers wrote:
>> monitoring.sgml has one </row> tag missing
> 
> Is that actually an issue? SGML allows skipping certain close tags, and
> IIRC row is one them.  We'll probably move to xml at some point not too
> far away, but I don't think it makes much sense to fix these 
> one-by-one.


Well, I have only used  make oldhtml  before now so maybe I am doing 
something wrong.

I try to run  make html.

First, I got this (just showing first few of a 75x repeat):

$ time ( cd /home/aardvark/pg_stuff/pg_sandbox/pgsql.HEAD/doc/src/sgml;  
make html; )
osx -D . -D . -x lower postgres.sgml >postgres.xml.tmp
osx:monitoring.sgml:1278:12:E: document type does not allow element 
"ROW" here
osx:monitoring.sgml:1282:12:E: document type does not allow element 
"ROW" here
osx:monitoring.sgml:1286:12:E: document type does not allow element 
"ROW" here
...
osx:monitoring.sgml:1560:12:E: document type does not allow element 
"ROW" here
osx:monitoring.sgml:1564:13:E: end tag for "ROW" omitted, but OMITTAG NO 
was specified
osx:monitoring.sgml:1275:8: start tag was here
make: *** [postgres.xml] Error 1


After closing that tag with </row> ,  make html  still fails:



$ time ( cd /home/aardvark/pg_stuff/pg_sandbox/pgsql.HEAD/doc/src/sgml;  
make html; )
osx -D . -D . -x lower postgres.sgml >postgres.xml.tmp
'/opt/perl-5.24/bin/perl' -p -e 

's/\[(aacute|acirc|aelig|agrave|amp|aring|atilde|auml|bull|copy|eacute|egrave|gt|iacute|lt|mdash|nbsp|ntilde|oacute|ocirc|oslash|ouml|pi|quot|scaron|uuml)

*\]/\&\1;/gi;' -e '$_ .= qq{<!DOCTYPE book PUBLIC "-//OASIS//DTD DocBook 
XML V4.2//EN" 
"http://www.oasis-open.org/docbook/xml/4.2/docbookx.dtd">\n} if $. == 
1;' <postgres.xml.tmp > postgres.xml
rm postgres.xml.tmp
xmllint --noout --valid postgres.xml
xsltproc --stringparam pg.version '10devel'  stylesheet.xsl postgres.xml
runtime error: file stylesheet-html-common.xsl line 41 element 
call-template
The called template 'id.attribute' was not found.
runtime error: file stylesheet-html-common.xsl line 41 element 
call-template
The called template 'id.attribute' was not found.
runtime error: file stylesheet-html-common.xsl line 41 element 
call-template
The called template 'id.attribute' was not found.
runtime error: file stylesheet-html-common.xsl line 41 element 
call-template
The called template 'id.attribute' was not found.
runtime error: file stylesheet-html-common.xsl line 41 element 
call-template
The called template 'id.attribute' was not found.
runtime error: file stylesheet-html-common.xsl line 30 element 
call-template
The called template 'id.attribute' was not found.
runtime error: file stylesheet-html-common.xsl line 30 element 
call-template
The called template 'id.attribute' was not found.
runtime error: file stylesheet-html-common.xsl line 30 element 
call-template
The called template 'id.attribute' was not found.
runtime error: file stylesheet-html-common.xsl line 30 element 
call-template
The called template 'id.attribute' was not found.
runtime error: file stylesheet-html-common.xsl line 30 element 
call-template
The called template 'id.attribute' was not found.
runtime error: file stylesheet-html-common.xsl line 30 element 
call-template
The called template 'id.attribute' was not found.
no result for postgres.xml
make: *** [html-stamp] Error 9

real    4m23.641s
user    4m22.304s
sys     0m0.914s


Any hints welcome...

thanks


$ cat /etc/redhat-release
CentOS release 6.6 (Final)

Hi,

On 2017-04-07 23:00:01 +0200, Erik Rijkers wrote:
> On 2017-04-07 22:50, Andres Freund wrote:
> > On 2017-04-07 22:47:55 +0200, Erik Rijkers wrote:
> > > monitoring.sgml has one </row> tag missing
> > 
> > Is that actually an issue? SGML allows skipping certain close tags, and
> > IIRC row is one them.  We'll probably move to xml at some point not too
> > far away, but I don't think it makes much sense to fix these one-by-one.
> 
> 
> Well, I have only used  make oldhtml  before now so maybe I am doing
> something wrong.
> 
> I try to run  make html.
> 
> First, I got this (just showing first few of a 75x repeat):
> 
> $ time ( cd /home/aardvark/pg_stuff/pg_sandbox/pgsql.HEAD/doc/src/sgml;
> make html; )
> osx -D . -D . -x lower postgres.sgml >postgres.xml.tmp
> osx:monitoring.sgml:1278:12:E: document type does not allow element "ROW"
> here

> xmllint --noout --valid postgres.xml
> xsltproc --stringparam pg.version '10devel'  stylesheet.xsl postgres.xml
> runtime error: file stylesheet-html-common.xsl line 41 element call-template
> The called template 'id.attribute' was not found.
> runtime error: file stylesheet-html-common.xsl line 41 element call-template


> Any hints welcome...
> 
> $ cat /etc/redhat-release
> CentOS release 6.6 (Final)

I think this means that your tools are too old.  See e.g.
http://archives.postgresql.org/message-id/21063.1491231996%40sss.pgh.pa.us

Greetings,

Andres Freund

On 4/7/17 16:47, Erik Rijkers wrote:
> monitoring.sgml has one </row> tag missing

fixed

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

On 4/7/17 16:50, Andres Freund wrote:
> On 2017-04-07 22:47:55 +0200, Erik Rijkers wrote:
>> monitoring.sgml has one </row> tag missing
> 
> Is that actually an issue? SGML allows skipping certain close tags, and
> IIRC row is one them.

The issue is a weird one.  For some reason, older tool chains complain
about this, but newer ones only complain about it when you use certain
warning options.  The mistake here was basically that the osx calls in
the makefile didn't enable those options, so users of newer tool chains
didn't see any complaints.  I have fixed that now.

For clarification, SGML allows applications of SGML to declare whether
they want to allow omitting tags.  HTML (<5) does so.  DocBook does not.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services