Обсуждение: [COMMITTERS] pgsql: Fix bugs in RelationGetPartitionDispatchInfo.
Fix bugs in RelationGetPartitionDispatchInfo. The previous coding was not quite right for cases involving multiple levels of partitioning. Amit Langote Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/a25665088d812d08bb888e961f208eaebf522050 Modified Files -------------- src/backend/catalog/partition.c | 39 +++++++++++++++++++++++++++++++++------ 1 file changed, 33 insertions(+), 6 deletions(-)
Hmm, Dmitry Ivanov spotted this bug [1]. And he posted this patch with only difference of variables naming and comments [2]. But he is not mentioned in commit message. That doesn't look fine.
2. https://www.postgresql.org/message-id/0d5b64c9-fa05-4dab-93e7-56576d1193ca%40postgrespro.ru------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
On Tue, Dec 13, 2016 at 7:32 PM, Robert Haas <rhaas@postgresql.org> wrote:
Fix bugs in RelationGetPartitionDispatchInfo.
The previous coding was not quite right for cases involving multiple
levels of partitioning.
Amit Langote
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/ a25665088d812d08bb888e961f208e aebf522050
Modified Files
--------------
src/backend/catalog/partition.c | 39 ++++++++++++++++++++++++++++++ +++------
1 file changed, 33 insertions(+), 6 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
On Wed, Dec 14, 2016 at 1:18 AM, Alexander Korotkov <a.korotkov@postgrespro.ru> wrote: > Hmm, Dmitry Ivanov spotted this bug [1]. And he posted this patch with only > difference of variables naming and comments [2]. But he is not mentioned in > commit message. That doesn't look fine. > > 1. > https://www.postgresql.org/message-id/e6c56fe9-4b87-4f64-ac6f-bc99675f3f9e%40postgrespro.ru > 2. > https://www.postgresql.org/message-id/0d5b64c9-fa05-4dab-93e7-56576d1193ca%40postgrespro.ru You are correct. Sorry about that. I try to be careful about such things but obviously I dropped the ball on this one. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Hi Alexander, On 2016/12/14 15:18, Alexander Korotkov wrote: > Hmm, Dmitry Ivanov spotted this bug [1]. And he posted this patch with > only difference of variables naming and comments [2]. But he is not > mentioned in commit message. That doesn't look fine. I apologize for my part in failing to repeat in my description of the patch that I sent (which might perhaps be the only thing Robert saw) that Dmitry is the original author of the patch, in addition to being the discoverer of the bug. Thanks again! Thanks, Amit