Обсуждение: [PATCH] sv: Updating pg_controldata and pg_ctl.
Hello there, I offer a small set for updating two PO-files in Swedish: pg_ctl.po, pg_controldata.po The patch set is made against the master branch of the git repository, and thus invalidates the submission I have made to the Pgfoundry using a Patch ticket. The message files have been checked with the aid of a 9.4beta2 instance built on OpenIndiana version oi_151a9. Best regards, Mats Erik Andersson
Вложения
On 23-09-2014 18:10, Mats Erik Andersson wrote: > I offer a small set for updating two PO-files in Swedish: > Mats, do not send patches (read the steps in [1] -- specially step 4) instead send the whole file. > The patch set is made against the master branch of the git > repository, and thus invalidates the submission I have made > to the Pgfoundry using a Patch ticket. > > The message files have been checked with the aid of a 9.4beta2 > instance built on OpenIndiana version oi_151a9. > Do not do that. Use REL9_4_STABLE branch to 9.4 translations or grab the file in the 9.4 table [2]. [1] https://wiki.postgresql.org/wiki/NLS [2] http://babel.postgresql.org/ -- Euler Taveira Timbira - http://www.timbira.com.br/ PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento
tisdag den 23 september 2014 klockan 21:42 skrev Euler Taveira detta: > On 23-09-2014 18:10, Mats Erik Andersson wrote: > > I offer a small set for updating two PO-files in Swedish: > > > Mats, do not send patches (read the steps in [1] -- specially step 4) > instead send the whole file. Why are you then using Git? You should stick with the ticket tracker at Pgfoundry for such a workflow. > > The patch set is made against the master branch of the git > > repository, and thus invalidates the submission I have made > > to the Pgfoundry using a Patch ticket. > > > > The message files have been checked with the aid of a 9.4beta2 > > instance built on OpenIndiana version oi_151a9. > > > Do not do that. Use REL9_4_STABLE branch to 9.4 translations or grab the > file in the 9.4 table [2]. I did exactly that to arrive at the patch 0001.... http://babel.postgresql.org/po-9.4-branch/pg_controldata-sv.po http://babel.postgresql.org/po-9.4-branch/pg_ctl-sv.po My phrase "have been checked ... OpenIndiana" clearly does not say what you believe it does. Regards
On 24-09-2014 06:00, Mats Erik Andersson wrote: > tisdag den 23 september 2014 klockan 21:42 skrev Euler Taveira detta: >> On 23-09-2014 18:10, Mats Erik Andersson wrote: >>> I offer a small set for updating two PO-files in Swedish: >>> >> Mats, do not send patches (read the steps in [1] -- specially step 4) >> instead send the whole file. > > Why are you then using Git? You should stick with the ticket > tracker at Pgfoundry for such a workflow. > AFAICS we are using git to smooth the push task to official repo without granting access to it. Since po files have a lot of hunks, some of them could fail to apply. That's why we prefer the whole file. The tracker is another possibility because some translators does not have access to git.postgresql.org/git/pgtranslation/messages.git. -- Euler Taveira Timbira - http://www.timbira.com.br/ PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento
Mats Erik Andersson wrote: > tisdag den 23 september 2014 klockan 21:42 skrev Euler Taveira detta: > > On 23-09-2014 18:10, Mats Erik Andersson wrote: > > > I offer a small set for updating two PO-files in Swedish: > > > > > Mats, do not send patches (read the steps in [1] -- specially step 4) > > instead send the whole file. > > Why are you then using Git? You should stick with the ticket > tracker at Pgfoundry for such a workflow. Yeah, I mostly agree with Mats here --- that advice was written back when we were using CVS and as far as I recall we didn't even have pgfoundry to help us coordinate or the babel site which runs the merge steps, etc. It should work fine now to ship patches. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
On Wed, Sep 24, 2014 at 2:47 PM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote: > Mats Erik Andersson wrote: >> tisdag den 23 september 2014 klockan 21:42 skrev Euler Taveira detta: >> > On 23-09-2014 18:10, Mats Erik Andersson wrote: >> > > I offer a small set for updating two PO-files in Swedish: >> > > >> > Mats, do not send patches (read the steps in [1] -- specially step 4) >> > instead send the whole file. >> >> Why are you then using Git? You should stick with the ticket >> tracker at Pgfoundry for such a workflow. > > Yeah, I mostly agree with Mats here --- that advice was written back > when we were using CVS and as far as I recall we didn't even have > pgfoundry to help us coordinate or the babel site which runs the merge > steps, etc. It should work fine now to ship patches. Would you take in consideration using git as it is intended and have people saying "I've got a few bits of Swedish translated, you can get them from (accessible git url - github or anything else)". A committer could cherry-pick them from the provided source so that even if there were commits in other languages after the contributor forked his repos it would result in no conflict. -- Daniele
Daniele Varrazzo wrote: > Would you take in consideration using git as it is intended and have > people saying "I've got a few bits of Swedish translated, you can get > them from (accessible git url - github or anything else)". A committer > could cherry-pick them from the provided source so that even if there > were commits in other languages after the contributor forked his repos > it would result in no conflict. Yeah, I was going to mention that but decided to kept the email short. I have no problem using additional remotes to cherry-pick from. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
On Wed, Sep 24, 2014 at 4:00 PM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote: > Daniele Varrazzo wrote: > >> Would you take in consideration using git as it is intended and have >> people saying "I've got a few bits of Swedish translated, you can get >> them from (accessible git url - github or anything else)". A committer >> could cherry-pick them from the provided source so that even if there >> were commits in other languages after the contributor forked his repos >> it would result in no conflict. > > Yeah, I was going to mention that but decided to kept the email short. > I have no problem using additional remotes to cherry-pick from. We can try that with Mats if he wants: if he forks the pgtranslation/messages.git and commits his changes in a "9.4-se" branch or something like that we could be able to merge his change no problems from there. We may then use the bug tracker only to be notified that there is something to merge and where to fetch it. A mirror of pgtranslation/messages.git on github would be helpful too, but not necessary. -- Daniele
Daniele Varrazzo wrote: > A mirror of pgtranslation/messages.git on github would be helpful too, > but not necessary. Please don't. At that point people start expecting github pull requests to work. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services